8000 Python Array API New Operators Tracker · Issue #58742 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Python Array API New Operators Tracker #58742

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
18 of 28 tasks
Tracked by #58743
pmeier opened this issue May 21, 2021 · 3 comments
Open
18 of 28 tasks
Tracked by #58743

Python Array API New Operators Tracker #58742

pmeier opened this issue May 21, 2021 · 3 comments
Labels
module: python array api Issues related to the Python Array API tracker A tracking issue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pmeier
Copy link
Collaborator
pmeier commented May 21, 2021

The array API specification stipulates the following operators that are currently not supported by PyTorch:

cc @mruberry @rgommers @pmeier

@pmeier pmeier added the module: python array api Issues related to the Python Array API label May 21, 2021
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 24, 2021
@mruberry mruberry added the tracker A tracking issue label May 30, 2021
@mruberry mruberry changed the title Operator tracker for array API compatibility Python Array API Tracker May 30, 2021
@mruberry mruberry changed the title Python Array API Tracker Python Array API New Operators Tracker May 30, 2021
@kmaehashi
Copy link
Contributor

cc/ @asi1024 @emcastillo

@AnirudhDagar
Copy link
Contributor

Hi,
I'd like to pick the concat alias issue as my first contribution to pytorch. array-api states the use of concat. PyTorch currently has cat while NumPy has concatenate (but the array_api namespace being added to numpy soon will also have concat, see numpy/numpy#18585).

I see that the expand_dims alias in #57116 is on hold for some reason, hence wanted to confirm before I proceed with this. Thanks!

@mruberry
Copy link
Collaborator

Hi,
I'd like to pick the concat alias issue as my first contribution to pytorch. array-api states the use of concat. PyTorch currently has cat while NumPy has concatenate (but the array_api namespace being added to numpy soon will also have concat, see numpy/numpy#18585).

I see that the expand_dims alias in #57116 is on hold for some reason, hence wanted to confirm before I proceed with this. Thanks!

Adding the alias would be great! expand_dims is on hold just because a dependency of PyTorch also defines an expand_dims function in a way where they can't build with PyTorch if it's added, and we're working with them to resolve this issue. This complication is atypical and unlikely to affect other aliases.

facebook-github-bot pushed a commit that referenced this issue Feb 14, 2022
Summary:
Part of #58742

Pull Request resolved: #70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
pytorchmergebot pushed a commit that referenced this issue Feb 14, 2022
Summary:
Part of #58742

Pull Request resolved: #70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f1)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 15, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 15, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 15, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 16, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 16, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 17, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 20, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 20, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Feb 21, 2022
Summary:
Part of pytorch/pytorch#58742

Pull Request resolved: pytorch/pytorch#70543

Reviewed By: soulitzer

Differential Revision: D34172475

Pulled By: mruberry

fbshipit-source-id: d498764b8651a8b7a19181b3421aeebf28a5db2b
(cherry picked from commit 05332f164c4317e46e1242fdae483204e0412ef3)
amjames added a commit that referenced this issue May 13, 2022
The `pow_` method should be connected to `Tensor.__ipow__` so that the
operator `**=` works correctly.

Part of #58742

[ghstack-poisoned]
amjames added a commit that referenced this issue May 13, 2022
The `pow_` method should be connected to `Tensor.__ipow__` so that the
operator `**=` works correctly.

Part of #58742

[ghstack-poisoned]
amjames added a commit that referenced this issue May 14, 2022
The `pow_` method should be connected to `Tensor.__ipow__` so that the
operator `**=` works correctly.

Part of #58742

[ghstack-poisoned]
amjames added a commit that referenced this issue May 14, 2022
The `pow_` method should be connected to `Tensor.__ipow__` so that the
operator `**=` works correctly.

Part of #58742

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: python array api Issues related to the Python Array API tracker A tracking issue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

5 participants
0