[caffe2] Remove IValue include from operator.h #67094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt as often when developing PyTorch. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
❌ 1 New FailuresAs of commit 4357043 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Oct 22, 2021
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt as often when developing PyTorch. [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt as often when developing PyTorch. [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt as often when developing PyTorch. [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dagitses
approved these changes
Nov 17, 2021
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
|
@dagitses PTAL |
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
…m operator.h" ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
8000
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/67094
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 02def0c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@dagitses has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
|
Rebased |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Jan 23, 2023
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. ghstack-source-id: dc1c8c2 Pull Request resolved: pytorch#67094
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ivalue.h includes Tensor.h, so creating a compilation barrier between
operator.h and ivalue.h means non-exported caffe2 ops don't need to be
rebuilt when developing PyTorch.
Differential Revision: D32289812