8000 Update on "[caffe2] Remove IValue include from operator.h" · pytorch/pytorch@0def3a9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0def3a9

Browse files
peterbell10peterbell10
committed
Update on "[caffe2] Remove IValue include from operator.h"
ivalue.h includes Tensor.h, so creating a compilation barrier between operator.h and ivalue.h means non-exported caffe2 ops don't need to be rebuilt when developing PyTorch. Differential Revision: [D32289812](https://our.internmc.facebook.com/intern/diff/D32289812) [ghstack-poisoned]
2 parents 907b75b + b791627 commit 0def3a9

File tree

1,583 files changed

+76614
-39905
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,583 files changed

+76614
-39905
lines changed

‎.bazelrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
build --copt=--std=c++14
22
build --copt=-I.
33
build --copt=-isystem --copt bazel-out/k8-fastbuild/bin
4+
build --experimental_ui_max_stdouterr_bytes=2048576
45

56
# Configuration to disable tty features for environments like CI
67
build:no-tty --curses no
@@ -11,3 +12,8 @@ build:no-tty --show_progress_rate_limit 10
1112
build:gpu --define=cuda=true
1213
# define a separate build folder for faster switching between configs
1314
build:gpu --platform_suffix=-gpu
15+
# rules_cuda configuration
16+
build:gpu --@rules_cuda//cuda:enable_cuda
17+
build:gpu --@rules_cuda//cuda:cuda_targets=sm_52
18+
build:gpu --@rules_cuda//cuda:compiler=nvcc
19+
build:gpu --repo_env=CUDA_PATH=/usr/local/cuda

‎.circleci/cimodel/data/dimensions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
GPU_VERSIONS = [None] + ["cuda" + v for v in CUDA_VERSIONS] + ROCM_VERSION_LABELS
1919

2020
STANDARD_PYTHON_VERSIONS = [
21-
"3.6",
2221
"3.7",
2322
"3.8",
2423
"3.9"

‎.circleci/cimodel/data/simple/android_definitions.py

Lines changed: 0 additions & 103 deletions
This file was deleted.

‎.circleci/cimodel/data/simple/nightly_android.py

Lines changed: 0 additions & 77 deletions
This file was deleted.

‎.circleci/cimodel/data/simple/nightly_ios.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55
class IOSNightlyJob:
66
def __init__(self,
77
variant,
8+
is_full_jit=False,
89
is_upload=False):
910

1011
self.variant = variant
12+
self.is_full_jit = is_full_jit
1113
self.is_upload = is_upload
1214

1315
def get_phase_name(self):
@@ -17,8 +19,11 @@ def get_common_name_pieces(self, with_version_dots):
1719

1820
extra_name_suffix = [self.get_phase_name()] if self.is_upload else []
1921

22+
extra_name = ["full_jit"] if self.is_full_jit else []
23+
2024
common_name_pieces = [
2125
"ios",
26+
] + extra_name + [
2227
] + ios_definitions.XCODE_VERSION.render_dots_or_parts(with_version_dots) + [
2328
"nightly",
2429
self.variant,
@@ -31,7 +36,8 @@ def gen_job_name(self):
3136
return "_".join(["pytorch"] + self.get_common_name_pieces(False))
3237

3338
def gen_tree(self):
34-
extra_requires = [x.gen_job_name() for x in BUILD_CONFIGS] if self.is_upload else []
39+
build_configs = BUILD_CONFIGS_FULL_JIT if self.is_full_jit else BUILD_CONFIGS
40+
extra_requires = [x.gen_job_name() for x in build_configs] if self.is_upload else []
3541

3642
props_dict = {
3743
"build_environment": "-".join(["libtorch"] + self.get_common_name_pieces(True)),
@@ -47,6 +53,9 @@ def gen_tree(self):
4753
props_dict["use_metal"] = miniutils.quote(str(int(True)))
4854
props_dict["use_coreml"] = miniutils.quote(str(int(True)))
4955

56+
if self.is_full_jit:
57+
props_dict["lite_interpreter"] = miniutils.quote(str(int(False)))
58+
5059
template_name = "_".join([
5160
"binary",
5261
"ios",
@@ -61,9 +70,14 @@ def gen_tree(self):
6170
IOSNightlyJob("arm64"),
6271
]
6372

73+
BUILD_CONFIGS_FULL_JIT = [
74+
IOSNightlyJob("x86_64", is_full_jit=True),
75+
IOSNightlyJob("arm64", is_full_jit=True),
76+
]
6477

65-
WORKFLOW_DATA = BUILD_CONFIGS + [
66-
IOSNightlyJob("binary", is_upload=True),
78+
WORKFLOW_DATA = BUILD_CONFIGS + BUILD_CONFIGS_FULL_JIT + [
79+
IOSNightlyJob("binary", is_full_jit=False, is_upload=True),
80+
IOSNightlyJob("binary", is_full_jit=True, is_upload=True),
6781
]
6882

6983

0 commit comments

Comments
 (0)
0