-
Notifications
You must be signed in to change notification settings - Fork 24.3k
[ROCm] Added unit test to test the cuda_pluggable allocator #154041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Added unit test to test the cuda_pluggable allocator #154041
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154041
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Unrelated FailureAs of commit 37a6c6b with merge base 2618977 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5f2b245
to
85a1901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Tested it locally, and these UTs pass. |
@pytorchmergebot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
… the apex setup.py to build nccl_allocator extension
Successfully rebased |
a4bfd67
to
cf5f547
Compare
@pytorchbot label "ciflow/periodic" |
Hi @amd-sriram please fix failing lint |
@pytorchbot label "ciflow/rocm" |
@pytorchmergebot merge -f "all required tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot cherry-pick --onto release/2.7 -c critical |
Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex Pull Request resolved: #154041 Approved by: https://github.com/atalman, https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com> (cherry picked from commit c2660d2)
Cherry picking #154041The cherry pick PR is at #154135 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
[ROCm] Added unit test to test the cuda_pluggable allocator (#154041) Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex Pull Request resolved: #154041 Approved by: https://github.com/atalman, https://github.com/jeffdaily (cherry picked from commit c2660d2) Co-authored-by: skishore <sriramkumar.kishorekumar@amd.com> Co-authored-by: Jithun Nair <jithun.nair@amd.com>
Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension
This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd