8000 [ROCm] Added unit test to test the cuda_pluggable allocator by amd-sriram · Pull Request #154041 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[ROCm] Added unit test to test the cuda_pluggable allocator #154041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

amd-sriram
Copy link
Contributor
@amd-sriram amd-sriram commented May 21, 2025

Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension

This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

Copy link
pytorch-bot bot commented May 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154041

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 37a6c6b with merge base 2618977 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels May 21, 2025
@amd-sriram amd-sriram force-pushed the Add_ut_test_cuda_pluggable_allocator branch from 5f2b245 to 85a1901 Compare May 21, 2025 18:09
@jithunnair-amd jithunnair-amd requested review from malfet and atalman May 21, 2025 18:37
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amd-sriram
Copy link
Contributor Author

Tested it locally, and these UTs pass.

@atalman
Copy link
Contributor
atalman commented May 22, 2025

@pytorchmergebot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased Add_ut_test_cuda_pluggable_allocator onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout Add_ut_test_cuda_pluggable_allocator && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the Add_ut_test_cuda_pluggable_allocator branch from a4bfd67 to cf5f547 Compare May 22, 2025 00:20
@amd-sriram
Copy link
Con 8000 tributor Author

@pytorchbot label "ciflow/periodic"

@pytorch-bot pytorch-bot bot added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label May 22, 2025
@atalman
Copy link
Contributor
atalman commented May 22, 2025

Hi @amd-sriram please fix failing lint

@pytorch-bot pytorch-bot bot removed the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label May 22, 2025
@amd-sriram
Copy link
Contributor Author

@pytorchbot label "ciflow/rocm"

@pytorch-bot pytorch-bot bot added the ciflow/rocm Trigger "default" config CI on ROCm label May 22, 2025
@atalman
Copy link
Contributor
atalman commented May 22, 2025

@pytorchmergebot merge -f "all required tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor
atalman commented May 22, 2025

@pytorchbot cherry-pick --onto release/2.7 -c critical

pytorchbot pushed a commit that referenced this pull request May 22, 2025
Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension

This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex

Pull Request resolved: #154041
Approved by: https://github.com/atalman, https://github.com/jeffdaily

Co-authored-by: Jithun Nair <jithun.nair@amd.com>
(cherry picked from commit c2660d2)
@pytorchbot
Copy link
Collaborator

Cherry picking #154041

The cherry pick PR is at #154135 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request May 22, 2025
[ROCm] Added unit test to test the cuda_pluggable allocator  (#154041)

Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension

This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex

Pull Request resolved: #154041
Approved by: https://github.com/atalman, https://github.com/jeffdaily


(cherry picked from commit c2660d2)

Co-authored-by: skishore <sriramkumar.kishorekumar@amd.com>
Co-authored-by: Jithun Nair <jithun.nair@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0