[ROCm] Update CUDAPluggableAllocator.h #152179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX. See PR ROCm/apex#184 Related Issue : https://ontrack-internal.amd.com/browse/SWDEV-519796
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152179
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: rocm" |
|
@pytorchbot label "ciflow/periodic" |
|
To add these label(s) (ciflow/periodic) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 22, 2025
Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex Pull Request resolved: #154041 Approved by: https://github.com/atalman, https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com>
pytorchbot
pushed a commit
that referenced
this pull request
May 22, 2025
Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex Pull Request resolved: #154041 Approved by: https://github.com/atalman, https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com> (cherry picked from commit c2660d2)
atalman
pushed a commit
that referenced
this pull request
May 22, 2025
[ROCm] Added unit test to test the cuda_pluggable allocator (#154041) Added unit test to include the cuda_pluggable allocator and replicate the apex setup.py to build nccl_allocator extension This test to check if this commit #152179 helps to build the cuda pluggable allocator in Rocm/Apex Pull Request resolved: #154041 Approved by: https://github.com/atalman, https://github.com/jeffdaily (cherry picked from commit c2660d2) Co-authored-by: skishore <sriramkumar.kishorekumar@amd.com> Co-authored-by: Jithun Nair <jithun.nair@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altering the flag to use the correct streamType in CUDAPluggableAllocator class for ROCm gpu. The flag TORCH_HIP_VERSION does not work for ROCm as intended. This flag is replaced with USE_ROCM. This is impacting Distributed Fused Adam in Rocm/APEX when using nccl_ub feature. This has been tested with rocm/apex.
See PR ROCm/apex#184
Related Commit - ROCm/apex@6fd8b50
ROCm@39a799f - rocm/pytorch [release/2.7]
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @jeffdaily @sunway5 8000 13 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @gujinghui @PenghuiCheng @jianyuh @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal @ezyang @SherlockNoMad @EikanWang @wenzhe-nrv @voznesenskym @penguinwu @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov