8000 [SymmMem] Speed up tests by kwen2501 · Pull Request #153677 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[SymmMem] Speed up tests #153677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gh/kwen2501/154/base
Choose a base branch
from
Open

[SymmMem] Speed up tests #153677

wants to merge 1 commit into from

Conversation

kwen2501
Copy link
Contributor
@kwen2501 kwen2501 commented May 16, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Use MultiProcContinousTest to avoid re-create ProcessGroup in each test instance.

@kwen2501
Update
e05e0b3 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153677

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 1 Cancelled Job

As of commit e05e0b3 with merge base fa85434 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels May 16, 2025
kwen2501 added a commit that referenced this pull request May 16, 2025
@kwen2501
[SymmMem] Speed up tests
ce69368 
ghstack-source-id: 9b6f66e
Pull-Request-resolved: #153677
@kwen2501 kwen2501 mentioned this pull request May 16, 2025
Open
@kwen2501 kwen2501 requested review from ngimel and fegin May 16, 2025 01:49
fegin
fegin approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor
@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failing tests looks like from the previous PR.

ngimel
ngimel approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator
@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! How long to symm mem tests run now?

test/distributed/test_symmetric_memory.py
@@ -887,7 +806,9 @@ def test_one_shot_all_reduce(self) -> None:
for dtype, size_bytes, align_bytes, copy, offset in itertools.product(
[torch.float, torch.bfloat16],
[4, 8192, 8196],
[4, 8, 16],
[
8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interetsint, do you know why memory usage changed? All these tests use very little memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@fegin fegin fegin approved these changes

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwen2501 @Skylion007 @fegin @ngimel
0