[Distributed][CI] Rework continuous TestCase #153653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153653
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New FailuresAs of commit 6f6d7de with merge base fa85434 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kwen2501
commented
May 15, 2025
fegin
approved these changes
May 16, 2025
| # Rendezvous file | ||
| rdvz_file: Optional[str] = None | ||
| # timeout configured per class | ||
| timeout: timedelta = timedelta(seconds=120) | ||
|
|
||
| @classmethod | ||
| @abc.abstractmethod | ||
| def backend_str(cls) -> str: | ||
| def backend_str(cls) -> str | None: |
There was a problem hiding this comment.
PyTorch is still using Python 3.9, which doesn't support | (this supports in Python 3.10)
fduwjj
approved these changes
May 16, 2025
| # number of test processes | ||
| world_size: int = 2 | ||
| world_size: int = -2 # unset state |
There was a problem hiding this comment.
why are we changing this to -2?
|
|
||
| @classmethod | ||
| def _run_test_given_id(cls, test_id: str, **kwargs) -> None: | ||
| # self.id() == e.g. '__main__.TestDistributed.TestAdditive.test_get_rank' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Reworked
MultiProcContinousTestto spawn processes duringsetUpClassinstead ofmain(so that we can support multiple TestClass'es in one file).The child processes are now an infinite loop, monitoring test IDs passed from main process via a task queue. Reciprocally, the child processes inform the main process completion of a test via a completion queue.
Added a test template.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k