[executorch][codegen] support function + method variants. #153651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153651
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit dc1b3f8 with merge base b8fad78 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D74834513 |
…3651) Summary: Previously think we didnt need this so just threw an exception. Now we are adding index_put_ and other inplace ops besides copy_ (which is only function variant) so adding it. Test Plan: current ci and manuels diff Differential Revision: D74834513
e76b5c3 to
dc1b3f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D74834513 |
larryliu0820
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously think we didnt need this so just threw an exception. Now we are adding index_put_ and other inplace ops besides copy_ (which is only function variant) so adding it.
Test Plan: current ci and manuels diff
Differential Revision: D74834513