Change trigger for autoformat, use --all-files (#153289)

clee2000 · pytorchmergebot · commit b8fad785d5f7 · 2025-05-15T20:38:33.000Z
Change trigger for auto format to be pull_request b/c the reusable action used gets the pr number from the pull_request event context, but only run it if ciflow/autoformat is attached to the PR. Tested this on a different PR, and it seems to be working Changed tag name because ciflow prefixed labels have special handling Also change to run on all files so it will mimic the normal CI lintrunner call, and because lintrunner, either by itself or using -m mergebase can miss some things. Idk if it would miss for format, but it does for checking lint. Format seems to take shorter than normal lint. I don't know if the comment about making suggestions on non edited file changes is a concern. I didn't really test this part Pull Request resolved: #153289 Approved by: https://github.com/atalman, https://github.com/malfet
diff --git a/.github/pytorch-probot.yml b/.github/pytorch-probot.yml
@@ -25,7 +25,6 @@ ciflow_push_tags:
 - ciflow/unstable
 - ciflow/xpu
 - ciflow/torchbench
-- ciflow/autoformat
 - ciflow/op-benchmark
 - ciflow/pull
 - ciflow/h100
diff --git a/.github/workflows/lint-autoformat.yml b/.github/workflows/lint-autoformat.yml
@@ -1,18 +1,16 @@
 name: Apply lint suggestions
 
 on:
-
-  push:
-    tags:
-      - ciflow/autoformat/*
+  pull_request:
+    types: [opened, synchronize, reopened, labeled, unlabeled]
 
 jobs:
   lintrunner-autoformat:
     permissions:
       contents: read
       pull-requests: write
     runs-on: lf.linux.2xlarge
-    if: ${{ github.repository_owner == 'pytorch' && github.event.pull_request.user.login != 'ezyang' && github.event.pull_request.user.login != 'malfet' && !startsWith(github.head_ref, 'export-') }}
+    if: ${{ github.repository_owner == 'pytorch' && contains(github.event.pull_request.labels.*.name, 'autoformat') }}
     steps:
       - name: Checkout pytorch
         uses: pytorch/pytorch/.github/actions/checkout-pytorch@main
@@ -21,12 +19,11 @@ jobs:
           fetch-depth: 0
       - name: Run lintrunner (nonretryable)
         continue-on-error: true
-        # we can't run all files here because only changes around where the diff are shown in the PR UI
         run: |
           set -ex
           python3 -m venv /tmp/venv
           source /tmp/venv/bin/activate
-          export ADDITIONAL_LINTRUNNER_ARGS="format"
+          export ADDITIONAL_LINTRUNNER_ARGS="format --all-files"
           bash .github/scripts/lintrunner.sh
       - name: Check for changes
         id: git-check
