8000 Remove 3.13 hack when installing TIMM by pytorchbot · Pull Request #153648 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Remove 3.13 hack when installing TIMM #153648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Remove 3.13 hack when installing TIMM #153648

merged 1 commit into from
May 15, 2025

Conversation

pytorchbot
Copy link
Collaborator
@pytorchbot pytorchbot commented May 15, 2025 •
edited by atalman
Loading

A Docker build failure showing up at this step triggered by the landing of #152362. Here is the example logs https://github.com/pytorch/pytorch/actions/runs/14718029881/job/41305891896:

#37 29.72 + as_jenkins conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124
#37 29.72 + sudo -E -H -u jenkins env -u SUDO_UID -u SUDO_GID -u SUDO_COMMAND -u SUDO_USER env PATH=/opt/conda/envs/py_3.13/bin:/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin LD_LIBRARY_PATH=/usr/local/nvidia/lib:/usr/local/nvidia/lib64 conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124
#37 49.50 ERROR: Cannot install torch and torchvision==0.22.0.dev20250226+cu124 because these package versions have conflicting dependencies.

This happens because we have stopped building 12.4 nightly for sometime. This hack doesn't apply anymore, so let's just remove it.

Cherry Pick Reason:
https://github.com/pytorch/pytorch/actions/runs/15033800672/job/42251708841

#43 57.27 The conflict is caused by:
#43 57.27     The user requested torch
#43 57.27     torchvision 0.22.0.dev20250226+cu124 depends on torch==2.7.0.dev20250226
#43 57.27 
#43 57.27 To fix this you could try to:
#43 57.27 1. loosen the range of package versions you've specified
#43 57.27 2. remove package versions to allow pip to attempt to solve the dependency conflict
#43 57.27 
#43 57.27 
#43 ERROR: process "/bin/sh -c if [ -n \"${INDUCTOR_BENCHMARKS}\" ]; then bash ./install_inductor_benchmark_deps.sh; fi" did not complete successfully: exit code: 1
------
 > [stage-0 35/72] RUN if [ -n "yes" ]; then bash ./install_inductor_benchmark_deps.sh; fi:
57.27 
57.27 The conflict is caused by:
57.27     The user requested torch
57.27     torchvision 0.22.0.dev20250226+cu124 depends on torch==2.7.0.dev20250226
57.27 
57.27 To fix this you could try to:
57.27 1. loosen the range of package versions you've specified
57.27 2. remove package versions to allow pip to attempt to solve the dependency conflict
57.27 
57.27 
------
Dockerfile:90
--------------------
  88 |     COPY ci_commit_pins/huggingface.txt huggingface.txt
  89 |     COPY ci_commit_pins/timm.txt timm.txt
  90 | >>> RUN if [ -n "${INDUCTOR_BENCHMARKS}" ]; then bash ./install_inductor_benchmark_deps.sh; fi
  91 |     RUN rm install_inductor_benchmark_deps.sh common_utils.sh timm.txt huggingface.txt
  92 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c if [ -n \"${INDUCTOR_BENCHMARKS}\" ]; then bash ./install_inductor_benchmark_deps.sh; fi" did not complete successfully: exit code: 1

@huydhn @pytorchbot
Remove 3.13 hack when installing TIMM (#152399)
cb5c09a 
A Docker build failure showing up at this step triggered by the landing of #152362.  Here is the example logs https://github.com/pytorch/pytorch/actions/runs/14718029881/job/41305891896:

```
#37 29.72 + as_jenkins conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124
#37 29.72 + sudo -E -H -u jenkins env -u SUDO_UID -u SUDO_GID -u SUDO_COMMAND -u SUDO_USER env PATH=/opt/conda/envs/py_3.13/bin:/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin LD_LIBRARY_PATH=/usr/local/nvidia/lib:/usr/local/nvidia/lib64 conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124
#37 49.50 ERROR: Cannot install torch and torchvision==0.22.0.dev20250226+cu124 because these package versions have conflicting dependencies.
```

This happens because we have stopped building 12.4 nightly for sometime.  This hack doesn't apply anymore, so let's just remove it.

Pull Request resolved: #152399
Approved by: https://github.com/cyyever, https://github.com/wdvr, https://github.com/malfet

(cherry picked from commit 5c01302)
@pytorchbot pytorchbot requested a review from jeffdaily as a code owner May 15, 2025 18:57
This was referenced May 15, 2025
Open
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153648

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 3 Cancelled Jobs, 48 Pending

As of commit cb5c09a with merge base 924a247 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 15, 2025
atalman
atalman approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 8af995f into release/2.7 May 15, 2025
81 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @atalman @huydhn
0