Remove 3.13 hack when installing TIMM #152399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <huydhn@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152399
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 117aaae with merge base 9c7b902 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
approved these changes
Apr 29, 2025
wdvr
approved these changes
Apr 29, 2025
malfet
approved these changes
Apr 29, 2025
|
@pytorchbot merge -f 'ROCm failures are from trunk' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
May 15, 2025
A Docker build failure showing up at this step triggered by the landing of #152362. Here is the example logs https://github.com/pytorch/pytorch/actions/runs/14718029881/job/41305891896: ``` #37 29.72 + as_jenkins conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124 #37 29.72 + sudo -E -H -u jenkins env -u SUDO_UID -u SUDO_GID -u SUDO_COMMAND -u SUDO_USER env PATH=/opt/conda/envs/py_3.13/bin:/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin LD_LIBRARY_PATH=/usr/local/nvidia/lib:/usr/local/nvidia/lib64 conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124 #37 49.50 ERROR: Cannot install torch and torchvision==0.22.0.dev20250226+cu124 because these package versions have conflicting dependencies. ``` This happens because we have stopped building 12.4 nightly for sometime. This hack doesn't apply anymore, so let's just remove it. Pull Request resolved: #152399 Approved by: https://github.com/cyyever, https://github.com/wdvr, https://github.com/malfet (cherry picked from commit 5c01302)
Cherry picking #152399The cherry pick PR is at #153648 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
atalman
pushed a commit
that referenced
this pull request
May 15, 2025
Remove 3.13 hack when installing TIMM (#152399) A Docker build failure showing up at this step triggered by the landing of #152362. Here is the example logs https://github.com/pytorch/pytorch/actions/runs/14718029881/job/41305891896: ``` #37 29.72 + as_jenkins conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124 #37 29.72 + sudo -E -H -u jenkins env -u SUDO_UID -u SUDO_GID -u SUDO_COMMAND -u SUDO_USER env PATH=/opt/conda/envs/py_3.13/bin:/opt/conda/bin:/usr/local/nvidia/bin:/usr/local/cuda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin LD_LIBRARY_PATH=/usr/local/nvidia/lib:/usr/local/nvidia/lib64 conda run -n py_3.13 pip install --progress-bar off --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu124 #37 49.50 ERROR: Cannot install torch and torchvision==0.22.0.dev20250226+cu124 because these package versions have conflicting dependencies. ``` This happens because we have stopped building 12.4 nightly for sometime. This hack doesn't apply anymore, so let's just remove it. Pull Request resolved: #152399 Approved by: https://github.com/cyyever, https://github.com/wdvr, https://github.com/malfet (cherry picked from commit 5c01302) Co-authored-by: Huy Do <huydhn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Docker build failure showing up at this step triggered by the landing of #152362. Here is the example logs https://github.com/pytorch/pytorch/actions/runs/14718029881/job/41305891896:
This happens because we have stopped building 12.4 nightly for sometime. This hack doesn't apply anymore, so let's just remove it.