8000 Enable manywheel build and smoke test on main branch for ROCm by jithunnair-amd · Pull Request #153287 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Enable manywheel build and smoke test on main branch for ROCm #153287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable manywheel build and smoke test on main branch for ROCm #153287

wants to merge 1 commit into from
+93 −1

Conversation

jithunnair-amd
Copy link
Collaborator
@jithunnair-amd jithunnair-amd commented May 9, 2025 •
edited by pytorch-bot bot
Loading

Fixes issue of not discovering breakage of ROCm wheel builds until the nightly job runs e.g. #153253

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153287

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6acd64e with merge base 7243c69 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels May 9, 2025
@jithunnair-amd jithunnair-amd added the ciflow/trunk Trigger trunk jobs on your pull request label May 10, 2025
@jeffdaily
Copy link
Collaborator

The current build failure was the motivation for this PR and is already fixed. Rebasing will clear the error.

@jeffdaily
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased enable_manywheel_smoke_test_for_rocm_on_main onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout enable_manywheel_smoke_test_for_rocm_on_main && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the 8000 enable_manywheel_smoke_test_for_rocm_on_main branch from d212d37 to 6acd64e Compare May 12, 2025 16:32
@jithunnair-amd
Copy link
Collaborator Author

Successfully triggered a build and test for rocm6.4 wheels:
image

@jithunnair-amd
Copy link
Collaborator Author

However, the build job took 12 mins for the "Download Build Artifacts" step on the ROCm runners, while it only takes 10s or less for the same step in the CUDA jobs. However, this isn't the case for the regular test jobs on the ROCm runners, e.g. this one
@atalman @huydhn Do you have any thoughts on how to address this? 30 mins for a binary smoke test job is excessive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jithunnair-amd @jeffdaily @pytorchmergebot @pytorchbot
0