8000 [ROCm][CI] fix nightly build after rocm 6.4 upgrade by amdfaa · Pull Request #153253 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ROCm][CI] fix nightly build after rocm 6.4 upgrade #153253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ROCm][CI] fix nightly build after rocm 6.4 upgrade #153253

wants to merge 1 commit into from

Conversation

amdfaa
Copy link
Contributor
@amdfaa amdfaa commented May 9, 2025 •
edited by pytorch-bot bot
Loading

rocm-smi adds inclusion of drm.h and libdrm-devel package was missing

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

@jeffdaily
[ROCm][CI] fix nightly build after rocm 6.4 upgrade
c1f4261 
rocm-smi adds inclusion of drm.h and libdrm-devel package was missing
@amdfaa amdfaa requested a review from jeffdaily as a code owner May 9, 2025 15:50
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153253

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c1f4261 with merge base 916f6ba (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels May 9, 2025
atalman
atalman approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jithunnair-amd jithunnair-amd mentioned this pull request May 9, 2025
Draft
@jithunnair-amd
Copy link
Collaborator

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd jithunnair-amd deleted the rocm64_fix_nightly_build branch May 9, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amdfaa @jeffdaily @pytorchmergebot @jithunnair-amd @atalman @pytorchbot
0