8000 Fix typo on `test_multi_device_context_manager` for XPU by guangyey · Pull Request #152812 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix typo on test_multi_device_context_manager for XPU #152812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix typo on test_multi_device_context_manager for XPU #152812

wants to merge 3 commits into from

Conversation

guangyey
Copy link
Collaborator
@guangyey guangyey commented May 5, 2025 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Motivation

Align #152474, fix the typo on UT for XPU introduced by #148864

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152812

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures

As of commit e5bb836 with merge base 0ffd31d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 5, 2025
guangyey added a commit that referenced this pull request May 5, 2025
@guangyey
Fix on XPU
ee7d28d 
ghstack-source-id: 1f8bbc8
Pull Request resolved: #152812
guangyey added a commit that referenced this pull request May 5, 2025
@guangyey
Fix on XPU
c09a3e0 
ghstack-source-id: 0c31c80
Pull Request resolved: #152812
@guangyey guangyey changed the title Fix on XPU Fix typo on test_multi_device_context_manager for XPU May 5, 2025
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label May 5, 2025
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label May 5, 2025
EikanWang
EikanWang approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@EikanWang EikanWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guangyey
Copy link
Collaborator Author
guangyey commented May 5, 2025

@pytorchbot rebase \

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 5, 2025

❌ 🤖 pytorchbot command failed:

Got EOF while in an escape sequence```
Try `@pytorchbot --help` for more info.

@guangyey
Copy link
Collaborator Author
guangyey commented May 5, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/144/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/152812)

pytorchmergebot pushed a commit that referenced this pull request May 5, 2025
@guangyey
Fix on XPU
3cc73a6 
ghstack-source-id: 9626b07
Pull Request resolved: #152812
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 3, 4, linux.idc.xpu)

Details for Dev Infra team Raised by workflow job

guangyey added 3 commits May 5, 2025 15:55
@guangyey
Update
e87bbab 
[ghstack-poisoned]
@guangyey
Update
b0251fd 
[ghstack-poisoned]
@guangyey
Update
e5bb836 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author
guangyey commented May 6, 2025

"The failures are irrelevant, we have issue a ticket to track them, refer to #152912"
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 4, 4, linux.idc.xpu), xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 1, 4, linux.idc.xpu), xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 3, 4, linux.idc.xpu), xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 2, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

91BA
@pytorchmergebot pytorchmergebot removed the merging label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@EikanWang EikanWang EikanWang approved these changes

@gujinghui gujinghui Awaiting requested review from gujinghui gujinghui is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guangyey @pytorchmergebot @Skylion007 @EikanWang @pytorchbot
0