8000 [CUDA] Fix `test_multi_device_context_manager` on CUDA by eqy · Pull Request #152474 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[CUDA] Fix test_multi_device_context_manager on CUDA #152474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CUDA] Fix test_multi_device_context_manager on CUDA #152474

wants to merge 1 commit into from

Conversation

eqy
Copy link
Collaborator
@eqy eqy commented Apr 29, 2025 •
edited by pytorch-bot bot
Loading

Seems there was a typo where set_device was called when the intent was to use current_device

As-is the test will fail on multigpu systems with

TypeError: set_device() missing 1 required positional argument: 'device'

cc @ptrblck @msaroufim @jerryzh168

@eqy eqy added module: multi-gpu Problem is related to running on multiple GPUs module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category labels Apr 29, 2025
@eqy eqy requested a review from guangyey April 29, 2025 21:45
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152474

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 94677b1 with merge base a3123dd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 30, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey guangyey mentioned this pull request May 5, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request May 6, 2025
@guangyey @pytorchmergebot
Fix typo on test_multi_device_context_manager for XPU (#152812)
35c727e 
# Motivation
Align #152474, fix the typo on UT for XPU introduced by #148864
Pull Request resolved: #152812
Approved by: https://github.com/EikanWang, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@guangyey guangyey Awaiting requested review from guangyey

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general module: multi-gpu Problem is related to running on multiple GPUs open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eqy @Skylion007 @pytorchmergebot
0