8000 Avoid overwriting COW data in MPS code by kurtamohler · Pull Request #150721 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Avoid overwriting COW data in MPS code #150721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: gh/kurtamohler/34/base
Choose a base branch
from
Open

Avoid overwriting COW data in MPS code #150721

wants to merge 31 commits into from

Conversation

kurtamohler
Copy link
Collaborator
@kurtamohler kurtamohler commented Apr 4, 2025 •
edited
Loading

Fixes MPS ops that were breaking COW behavior by overwriting data without first materializing. Along with necessary materializations, this also introduces many unnecessary materializations, but the MPS-CPU lazy cloning feature should now be safe to use.

Also introduces APIs in the MPS code which will be used in preventing unnecessary materializations in future PRs.

Stack from ghstack (oldest at bottom):

@kurtamohler
Update
18ef08e 
[ghstack-poisoned]
@kurtamohler kurtamohler mentioned this pull request Apr 4, 2025
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150721

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 1 Unrelated Failure

As of commit f94aa9d with merge base 56e1c23 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Apr 4, 2025
@kurtamohler kurtamohler mentioned this pull request Apr 4, 2025
Draft
@kurtamohler
Update
c523917 
[ghstack-poisoned]
@kurtamohler
Copy link
Collaborator Author
kurtamohler commented Apr 4, 2025 •
edited
Loading

To be confident that I didn't miss anything, I will have to add a test that runs through the op_db and confirm that no MPS operators mutate the underlying data of COW inputs. Basically it would be a reduced version of the test_cow_input test in test_ops.py, but it would allow materialization of any inputs and ONLY make sure that the underlying COW data doesn't change. In the future, we should enable the full test_cow_input on MPS, but it will take a significant amount of work to get that to pass

@kurtamohler
Update
64a7128 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 5, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
9c1186d 
ghstack-source-id: 063d9d0
Pull Request resolved: pytorch#150721
@kurtamohler
Update
4ed9da5 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 5, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
e7ff086 
ghstack-source-id: 10edf84
Pull Request resolved: pytorch#150721
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 7, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
879e9a6 
ghstack-source-id: 10edf84
Pull Request resolved: pytorch#150721
@kurtamohler
Update
6044ed7 
[ghstack-poisoned]
@kurtamohler
Update
a9c8d3c 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 7, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
966a3be 
ghstack-source-id: bc91047
Pull Request resolved: pytorch#150721
@kurtamohler kurtamohler added the keep-going Don't stop on first failure, keep running tests until the end label Apr 7, 2025
@kurtamohler
Update
4118c2e 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 7, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
f3e7ec4 
ghstack-source-id: 278497b
Pull Request resolved: pytorch#150721
@kurtamohler
Update
7fa7759 
[ghstack-poisoned]
@kurtamohler
Update
8a38f06 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 7, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
7676c62 
ghstack-source-id: c9c7b65
Pull Request resolved: pytorch#150721
@kurtamohler
Update
96166f4 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 8, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
b9c668d 
ghstack-source-id: a2c05ca
Pull Request resolved: pytorch#150721
Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
c1f30f0 
ghstack-source-id: 77de1e4
Pull Request resolved: pytorch/pytorch#150721
@kurtamohler
Update
7e72740 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 25, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
b486635 
ghstack-source-id: 5b304e2
Pull Request resolved: pytorch#150721
@kurtamohler
Update
8b7a4eb 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 28, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
2c8bbed 
ghstack-source-id: 3719e28
Pull Request resolved: pytorch#150721
@kurtamohler
Update
21b5762 
[ghstack-poisoned]
@kurtamohler
Update
9f352ee 
[ghstack-poisoned]
@kurtamohler
Update
23e5eb5 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 28, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
9e1f3bb 
ghstack-source-id: df7717f
Pull Request resolved: pytorch#150721
@kurtamohler
Update
fdf69ba 
[ghstack-poisoned]
@kurtamohler
Update
f9a9412 
[ghstack-poisoned]
@kurtamohler
Update
7e5889a 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 29, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
ab90fd7 
ghstack-source-id: a1783ae
Pull Request resolved: pytorch#150721
@kurtamohler
Update
533a848 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 29, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
dbb82b9 
ghstack-source-id: 2746d1f
Pull Request resolved: pytorch#150721
@kurtamohler
Update
005e924 
[ghstack-poisoned]
@kurtamohler
Update
35f57e9 
[ghstack-poisoned]
@kurtamohler
Update
158d3bc 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 30, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
c1e0870 
ghstack-source-id: 671272f
Pull Request resolved: pytorch#150721
@kurtamohler
Update
e8a8410 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 30, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
7abb200 
ghstack-source-id: a7e9ce0
Pull Request resolved: pytorch#150721
kurtamohler added 5 commits May 1, 2025 00:06
@kurtamohler
Update
a8050a4 
[ghstack-poisoned]
@kurtamohler
Update
830a1ad 
[ghstack-poisoned]
@kurtamohler
Update
3c3ea82 
[ghstack-poisoned]
@kurtamohler
Update
fbbdcc8 
[ghstack-poisoned]
@kurtamohler
Update
43320fd 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 1, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
a744297 
ghstack-source-id: 62fac33
Pull Request resolved: pytorch#150721
@kurtamohler
Update
16c87b0 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 13, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
302ca02 
ghstack-source-id: 62fac33
Pull Request resolved: pytorch#150721
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 14, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
f8a47bb 
ghstack-source-id: 62fac33
Pull Request resolved: pytorch#150721
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 16, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
6b523e8 
ghstack-source-id: 62fac33
Pull Request resolved: pytorch#150721
@kurtamohler
Update
f94aa9d 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 16, 2025
@kurtamohler
Avoid overwriting COW data in MPS code
b075d38 
ghstack-source-id: 20fca86
Pull Request resolved: pytorch#150721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) keep-going Don't stop on first failure, keep running tests until the end open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtamohler @pytorchbot
0