8000 Enable lazy cloning in `Tensor.to` between CPU and MPS by kurtamohler · Pull Request #150569 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Enable lazy cloning in Tensor.to between CPU and MPS #150569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: gh/kurtamohler/33/base
Choose a base branch
from
Draft

Enable lazy cloning in Tensor.to between CPU and MPS #150569

wants to merge 37 commits into from

Conversation

kurtamohler
Copy link
Collaborator
@kurtamohler kurtamohler commented Apr 2, 2025 •
edited
Loading

@kurtamohler
Update
c63231c 
[ghstack-poisoned]
@kurtamohler kurtamohler mentioned this pull request Apr 2, 2025
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150569

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 8fd51f9 with merge base 56e1c23 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler added a commit that referenced this pull request Apr 2, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
1d8798e 
ghstack-source-id: c92ef74
Pull Request resolved: #150569
@kurtamohler kurtamohler added release notes: lazy release notes category release notes: mps Release notes category and removed open source labels Apr 2, 2025
@kurtamohler
Copy link
Collaborator Author

Because of what I mentioned here, right now there is no guarantee that a COW MPS tensor will materialize when it should. I've found some places in the codebase where MPS ops cast the const data pointer to non-const and then mutate the data (for instance, any op that calls getMTLBufferStorage and then writes to the buffer). Those ops will incorrectly write to the underlying data of a COW tensor without materializing. So I think it would be best not to merge this PR until we fix the data pointer const-correctness in the MPS ops.

@kurtamohler kurtamohler marked this pull request as draft April 2, 2025 21:00
@kurtamohler
Update
a2f60c3 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 3, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
7ee9da0 
ghstack-source-id: ac5309c
Pull Request resolved: #150569
@kurtamohler
Update
825d03b 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 3, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
a907427 
ghstack-source-id: ac5309c
Pull Request resolved: pytorch#150569
kurtamohler added a commit that referenced this pull request Apr 3, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
cf61305 
ghstack-source-id: 057856d
Pull Request resolved: #150569
@kurtamohler
Update
ddccfba 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
6f78926 
ghstack-source-id: 902ece7
Pull Request resolved: #150569
@kurtamohler
Update
f926e4e 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
aef97bf 
ghstack-source-id: 902ece7
Pull Request resolved: pytorch#150569
kurtamohler added a commit that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
531e6a0 
ghstack-source-id: 3cd33fa
Pull Request resolved: #150569
@kurtamohler
Update
f06b57e 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
daeb6c8 
ghstack-source-id: 3cd33fa
Pull Request resolved: pytorch#150569
kurtamohler added a commit that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
cb1272b 
ghstack-source-id: 6f363f6
Pull Request resolved: #150569
@kurtamohler
Update
8dd4452 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
8f24812 
ghstack-source-id: 6f363f6
Pull Request resolved: pytorch#150569
@kurtamohler kurtamohler mentioned this pull request Apr 4, 2025
Open
kurtamohler added a commit that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
fee5bd0 
ghstack-source-id: 20c5f02
Pull Request resolved: #150569
@kurtamohler
Update
8ce0a44 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 4, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
544816f 
ghstack-source-id: 83cfe9e
Pull Request resolved: #150569
kurtamohler added a commit that referenced this pull request Apr 29, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
5718448 
ghstack-source-id: 6cccde2
Pull Request resolved: #150569
@kurtamohler
Update
852b3e0 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 29, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
06e04ae 
ghstack-source-id: fa61099
Pull Request resolved: #150569
@kurtamohler
Update
d4e3e2d 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 30, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
c08e75d 
ghstack-source-id: 65a4c5f
Pull Request resolved: #150569
@kurtamohler
Update
9167150 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 30, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
4615cc0 
ghstack-source-id: ba67420
Pull Request resolved: #150569
@kurtamohler
Update
8c2e2a8 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 30, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
c41fbc5 
ghstack-source-id: e508c76
Pull Request resolved: #150569
@kurtamohler
Update
bd20b89 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Apr 30, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
f7b929f 
ghstack-source-id: 6c1a950
Pull Request resolved: #150569
@kurtamohler
Update
be34de7 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 1, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
783d22f 
ghstack-source-id: f382e2f
Pull Request resolved: #150569
@kurtamohler
Update
0f438a7 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 1, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
1dfa452 
ghstack-source-id: b2facee
Pull Request resolved: #150569
@kurtamohler
Update
c254e37 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 1, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
38a59be 
ghstack-source-id: a6c604a
Pull Request resolved: #150569
@kurtamohler
Update
594d7c7 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 1, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
e98b3ce 
ghstack-source-id: e5f0395
Pull Request resolved: #150569
@cyyever
Copy link
Collaborator
cyyever commented May 1, 2025

Is it possible to extend the support to other kinds of devices?

@kurtamohler
Update
b9c9a95 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 1, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
3bff169 
ghstack-source-id: 0dd5075
Pull Request resolved: #150569
@kurtamohler
Copy link
Collaborator Author

Is it possible to extend the support to other kinds of devices?

In general probably not, but the answer depends on the platform. The reason this can work for CPU-MPS is that M-series Macs have a shared memory space that both the cpu and gpu can access

@kurtamohler
Update
e088508 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request May 2, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
0449bc1 
ghstack-source-id: 738d0b6
Pull Request resolved: #150569
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 13, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
689a7ce 
ghstack-source-id: 0dd5075
Pull Request resolved: pytorch#150569
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 14, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
6b6e236 
ghstack-source-id: 0dd5075
Pull Request resolved: pytorch#150569
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request May 16, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
59539f9 
ghstack-source-id: 0dd5075
Pull Request resolved: pytorch#150569
@kurtamohler
Update
8fd51f9 
[ghstack-poisoned]
kurtamohler 7A47 added a commit that referenced this pull request May 16, 2025
@kurtamohler
Enable lazy cloning in Tensor.to between CPU and MPS
e94ab35 
ghstack-source-id: 79b47df
Pull Request resolved: #150569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) open source release notes: lazy release notes category release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtamohler @cyyever @pytorchbot
0