[ONNX] Refactor dispatcher and registry #147396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147396
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 200da36 with merge base bd370c1 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 18, 2025
Refactor dispatcher and registry to 1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts 2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure 3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: fea9b1d Pull Request resolved: pytorch#147396
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 19, 2025
Refactor dispatcher and registry to 1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts 2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure 3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 4e551da Pull Request resolved: pytorch#147396 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 19, 2025
Refactor dispatcher and registry to 1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts 2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure 3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 4e551da Pull Request resolved: pytorch#147396 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
titaiwangms
approved these changes
Feb 19, 2025
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests. #139301 Pull Request resolved: #147392 Approved by: https://github.com/titaiwangms ghstack dependencies: #147396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR sets up the registry to accept onnx decomp functions to be moved into PyTorch (#139301).
The ops from onnx script are currently appended to the registry. When the ops are moved into PyTorch, the moved ops takes precedence because they appear first in the registry list.
After the migration hooks for loading ops from onnx script will be removed.
_pt_onnx_signatureto store function signatures to avoid conflictsSigned-off-by: Justin Chu justinchuby@users.noreply.github.com