8000 [ONNX] Refactor dispatcher and registry by justinchuby · Pull Request #147396 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ONNX] Refactor dispatcher and registry #147396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[ONNX] Refactor dispatcher and registry #147396

wants to merge 3 commits into from

Conversation

justinchuby
Copy link
Collaborator
@justinchuby justinchuby commented Feb 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR sets up the registry to accept onnx decomp functions to be moved into PyTorch (#139301).

The ops from onnx script are currently appended to the registry. When the ops are moved into PyTorch, the moved ops takes precedence because they appear first in the registry list.

After the migration hooks for loading ops from onnx script will be removed.

  1. Use a private field _pt_onnx_signature to store function signatures to avoid conflicts
  2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
  3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu justinchuby@users.noreply.github.com

@justinchuby
Update
c6e07d5 
[ghstack-poisoned]
This was referenced Feb 18, 2025
Closed
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 18, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147396

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 200da36 with merge base bd370c1 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

justinchuby added a commit that referenced this pull request Feb 18, 2025
@justinchuby
[ONNX] Refactor dispatcher and registry
c2eaf1c 
Refactor dispatcher and registry to
1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: fea9b1d
Pull Request resolved: #147396
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category labels Feb 18, 2025
@justinchuby justinchuby requested review from malfet and albanD February 18, 2025 20:24
@justinchuby justinchuby mentioned this pull request Feb 18, 2025
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 18, 2025
@justinchuby
[ONNX] Refactor dispatcher and registry
cbcfaf9 
Refactor dispatcher and registry to
1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: fea9b1d
Pull Request resolved: pytorch#147396
@justinchuby
Update
5b18961 
[ghstack-poisoned]
@justinchuby
Update
200da36 
[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
@justinchuby
[ONNX] Refactor dispatcher and registry
2805018 
Refactor dispatcher and registry to
1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 4e551da
Pull Request resolved: pytorch#147396

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@pytorch pytorch deleted a comment from pytorch-bot bot Feb 19, 2025
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 19, 2025
@justinchuby justinchuby mentioned this pull request Feb 19, 2025
Open
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
@justinchuby
[ONNX] Refactor dispatcher and registry
1d15de7 
Refactor dispatcher and registry to
1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 4e551da
Pull Request resolved: pytorch#147396

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
@justinchuby
[ONNX] Refactor dispatcher and registry
19b933f 
Refactor dispatcher and registry to
1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 4e551da
Pull Request resolved: pytorch#147396

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test, linux-binary-manywheel / manywheel-py3_9-cuda12_8-test / test

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Feb 19, 2025
@justinchuby @pytorchmergebot
[ONNX] Add scaffolding for onnx decomp and logic for op tests (#147392)
41ae15f 
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301
Pull Request resolved: #147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: #147396
Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
@justinchuby @Raymo111
[ONNX] Refactor dispatcher and registry (#147396)
25c7ea8 
This PR sets up the registry to accept onnx decomp functions to be moved into PyTorch (#139301).

The ops from onnx script are currently appended to the registry. When the ops are moved into PyTorch, the moved ops takes precedence because they appear first in the registry list.

After the migration hooks for loading ops from onnx script will be removed.

1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Pull Request resolved: #147396
Approved by: https://github.com/titaiwangms
Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
@justinchuby @Raymo111
[ONNX] Add scaffolding for onnx decomp and logic for op tests (#147392)
ab97fd3 
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301
Pull Request resolved: #147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: #147396
pytorch-bot bot pushed a commit that referenced this pull request Feb 24, 2025
@justinchuby @Ryo-not-rio
[ONNX] Refactor dispatcher and registry (#147396)
c46f86e 
This PR sets up the registry to accept onnx decomp functions to be moved into PyTorch (#139301).

The ops from onnx script are currently appended to the registry. When the ops are moved into PyTorch, the moved ops takes precedence because they appear first in the registry list.

After the migration hooks for loading ops from onnx script will be removed.

1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Pull Request resolved: #147396
Approved by: https://github.com/titaiwangms
pytorch-bot bot pushed a commit that referenced this pull request Feb 24, 2025
@justinchuby @Ryo-not-rio
[ONNX] Add scaffolding for onnx decomp and logic for op tests (#147392)
6445f02 
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301
Pull Request resolved: #147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: #147396
@justinchuby justinchuby mentioned this pull request Feb 27, 2025
Open
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@justinchuby @majing921201
[ONNX] Refactor dispatcher and registry (pytorch#147396)
64c61cb 
This PR sets up the registry to accept onnx decomp functions to be moved into PyTorch (pytorch#139301).

The ops from onnx script are currently appended to the registry. When the ops are moved into PyTorch, the moved ops takes precedence because they appear first in the registry list.

After the migration hooks for loading ops from onnx script will be removed.

1. Use a private field `_pt_onnx_signature` to store function signatures to avoid conflicts
2. Update the registry to record the signature in OnnxDecompMeta and update the dispatcher to leverage the data structure
3. Update registry to prepare for onnx op registration, and update the the onnx_impl decorator to support a no_compile option

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Pull Request resolved: pytorch#147396
Approved by: https://github.com/titaiwangms
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@justinchuby @majing921201
[ONNX] Add scaffolding for onnx decomp and logic for op tests (pytorc…
17debab 
…h#147392)

Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in pytorch#139301. It adds two ops: abs and add, and enables the related tests.

pytorch#139301
Pull Request resolved: pytorch#147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#147396
@github-actions github-actions bot deleted the gh/justinchuby/109/head branch March 27, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinchuby @pytorchmergebot @titaiwangms @pytorchbot
0