-
Notifications
You must be signed in to change notification settings - Fork 24.2k
[ONNX] Add scaffolding for onnx decomp and logic for op tests #147392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147392
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 269cd38 with merge base bd370c1 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
commented
Feb 18, 2025
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 3b8b80a Pull Request resolved: pytorch#147392 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 3b8b80a Pull Request resolved: pytorch#147392 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
titaiwangms
approved these changes
Feb 18, 2025
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 3291cb3 Pull Request resolved: pytorch#147392 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 3291cb3 Pull Request resolved: pytorch#147392 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 3291cb3 Pull Request resolved: pytorch#147392 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Raymo111
pushed a commit
that referenced
this pull request
Feb 20, 2025
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests. #139301 Pull Request resolved: #147392 Approved by: https://github.com/titaiwangms ghstack dependencies: #147396
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests. #139301 Pull Request resolved: #147392 Approved by: https://github.com/titaiwangms ghstack dependencies: #147396
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
…h#147392) Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in pytorch#139301. It adds two ops: abs and add, and enables the related tests. pytorch#139301 Pull Request resolved: pytorch#147392 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#147396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: onnx
Related to torch.onnx
open source
release notes: onnx
torch.onnx related changes that should show up in the release notes
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.
#139301