8000 [ONNX] Add scaffolding for onnx decomp and logic for op tests by justinchuby · Pull Request #147392 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[ONNX] Add scaffolding for onnx decomp and logic for op tests #147392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

justinchuby
Copy link
Collaborator
@justinchuby justinchuby commented Feb 18, 2025

Stack from ghstack (oldest at bottom):

Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301

[ghstack-poisoned]
Copy link
pytorch-bot bot commented Feb 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147392

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 269cd38 with merge base bd370c1 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 18, 2025
justinchuby added a commit that referenced this pull request Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: e8c252f
Pull Request resolved: #147392
@justinchuby justinchuby added module: onnx Related to torch.onnx release notes: onnx torch.onnx related changes that should show up in the release notes labels Feb 18, 2025
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3b8b80a
Pull Request resolved: #147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3b8b80a
Pull Request resolved: pytorch#147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 18, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3b8b80a
Pull Request resolved: pytorch#147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 32ad982
Pull Request resolved: #147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 1fb2f02
Pull Request resolved: #147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested review from malfet and albanD February 19, 2025 03:50
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3291cb3
Pull Request resolved: #147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3291cb3
Pull Request resolved: pytorch#147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3291cb3
Pull Request resolved: pytorch#147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 19, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby changed the title [ONNX] Add common logic for op test [ONNX] Add scaffolding for onnx decomp and logic for op test Feb 19, 2025
@justinchuby justinchuby changed the title [ONNX] Add scaffolding for onnx decomp and logic for op test [ONNX] Add scaffolding for onnx decomp and logic for op tests Feb 19, 2025
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Feb 19, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 3291cb3
Pull Request resolved: pytorch#147392

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301
Pull Request resolved: #147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: #147396
pytorch-bot bot pushed a commit that referenced this pull request Feb 24, 2025
Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in #139301. It adds two ops: abs and add, and enables the related tests.

#139301
Pull Request resolved: #147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: #147396
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
…h#147392)

Create scaffold for onnx op test data and common logic. This PR creates the scaffolding for new onnx decomp functions described in pytorch#139301. It adds two ops: abs and add, and enables the related tests.

pytorch#139301
Pull Request resolved: pytorch#147392
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#147396
@github-actions github-actions bot deleted the gh/justinchuby/108/head branch March 27, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0