Fix allow_mutation_on_saved_tensors for inplace foreach #145520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145520
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d8db1d6 with merge base e57cdb8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
commented
Jan 23, 2025
| # The same exact tensor has been cloned already | ||
| continue | ||
| ctx.cloned[handle] = ctx.original[handle].clone() | ||
| del ctx.original[handle] |
There was a problem hiding this comment.
unchanged - factored out to a function
[ghstack-poisoned]
albanD
approved these changes
Jan 23, 2025
| del ctx.original[handle] | ||
| if arg.is_out: | ||
| maybe_clone(kwargs["out"]) | ||
| elif isinstance(args[idx], list): |
There was a problem hiding this comment.
Are arguments always normalized as lists here? Or they could be any sequence?
There was a problem hiding this comment.
I think so - we rely the jit logic to convert ivalues to PyObjects which should always map ivalue list types to py::list.
This was referenced Jan 23, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 25, 2025
Fixes #117140 Pull Request resolved: #145531 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: #145520
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 25, 2025
Fixes #93045 #93044 From previous discussion #93045 (comment) the resolution is that we're okay with removing this. Some older attempts: - #102581 - #109249 Pull Request resolved: #145533 Approved by: https://github.com/lezcano, https://github.com/malfet ghstack dependencies: #145520, #145531
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jan 27, 2025
Pull Request resolved: pytorch#145520 Approved by: https://github.com/albanD
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jan 27, 2025
Fixes pytorch#117140 Pull Request resolved: pytorch#145531 Approved by: https://github.com/mikaylagawarecki ghstack dependencies: pytorch#145520
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jan 27, 2025
Fixes pytorch#93045 pytorch#93044 From previous discussion pytorch#93045 (comment) the resolution is that we're okay with removing this. Some older attempts: - pytorch#102581 - pytorch#109249 Pull Request resolved: pytorch#145533 Approved by: https://github.com/lezcano, https://github.com/malfet ghstack dependencies: pytorch#145520, pytorch#145531
nWEIdia
pushed a commit
to nWEIdia/pytorch
that referenced
this pull request
Jan 27, 2025
…torch#145399) Fixes pytorch#141292 Pull Request resolved: pytorch#145399 Approved by: https://github.com/jbschlosser ghstack dependencies: pytorch#145520, pytorch#145531, pytorch#145533
This was referenced Feb 3, 2025
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
ghstack-source-id: da6c632 Pull Request resolved: pytorch/pytorch#145520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):