8000 [NJT] Fix inference mode for composite implicit ops without nested-specific kernel by soulitzer · Pull Request #146633 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[NJT] Fix inference mode for composite implicit ops without nested-specific kernel #146633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[NJT] Fix inference mode for composite implicit ops without nested-specific kernel #146633

wants to merge 3 commits into from

Conversation

soulitzer
Copy link
Contributor
@soulitzer soulitzer commented Feb 6, 2025 •
edited
Loading

@soulitzer soulitzer mentioned this pull request Feb 3, 2025
Open
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146633

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9e27eb7 with merge base e57cdb8 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request Feb 6, 2025
@soulitzer
[NJT] Fix inference mode for composite implicit ops without nested-sp…
7b56b7d 
…ecific kernel

ghstack-source-id: 24bc8b7
Pull Request resolved: #146633
@soulitzer
Update on "[NJT] Fix inference mode for composite implicit ops withou…
3425f31 
…t nested-specific kernel"

[ghstack-poisoned]
@soulitzer soulitzer requested a review from jbschlosser February 6, 2025 20:02
soulitzer added a commit that referenced this pull request Feb 6, 2025
@soulitzer
[NJT] Fix inference mode for composite implicit ops without nested-sp…
60bff4d 
…ecific kernel

ghstack-source-id: 5d56ad1
Pull Request resolved: #146633
@soulitzer soulitzer added the release notes: nested tensor Changes that have a direct impact on nested tensors label Feb 6, 2025
@jbschlosser jbschlosser added the topic: bug fixes topic category label Feb 6, 2025
jbschlosser
jbschlosser approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find & fix! lgtm

@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 6, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Update on "[NJT] Fix inference mode for composite implicit ops withou…
9e27eb7 
…t nested-specific kernel"

[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Feb 6, 2025
@soulitzer
[NJT] Fix inference mode for composite implicit ops without nested-sp…
9035fd1 
…ecific kernel

ghstack-source-id: a72b64b
Pull Request resolved: #146633
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 6, 2025 22:01 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results February 6, 2025 22:01 Inactive
@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 6, 2025 22:01 Failure
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorch-bot pytorch-bot bot had a problem deploying to upload-benchmark-results February 7, 2025 22:39 Failure
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -f "job keeps timing out"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Raymo111 pushed a commit that referenced this pull request Feb 20, 2025
@soulitzer @Raymo111
[NJT] Fix inference mode for composite implicit ops without nested-sp…
076c9f3 
…ecific kernel (#146633)

Pull Request resolved: #146633
Approved by: https://github.com/jbschlosser
@soulitzer soulitzer mentioned this pull request Feb 26, 2025
Open
majing921201 pushed a commit to majing921201/pytorch that referenced this pull request Mar 4, 2025
@soulitzer @majing921201
[NJT] Fix inference mode for composite implicit ops without nested-sp…
dc7ab69 
…ecific kernel (pytorch#146633)

Pull Request resolved: pytorch#146633
Approved by: https://github.com/jbschlosser
@github-actions github-actions bot deleted the gh/soulitzer/352/head branch March 13, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soulitzer @pytorchmergebot @jbschlosser
0