8000 Resolve zip file permission issue when uploading artifacts on ROCm MI300 CI runners by amdfaa · Pull Request #145504 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Resolve zip file permission issue when uploading artifacts on ROCm MI300 CI runners #145504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

Resolve zip file permission issue when uploading artifacts on ROCm MI300 CI runners #145504

Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
bcc0285
Update _rocm-test.yml
amdfaa Jan 23, 2025
8147c63
Update rocm-mi300.yml
amdfaa Jan 23, 2025
c51e3b0
remove line since it self-referential
amdfaa Jan 23, 2025
581eead
Update rocm-mi300.yml
amdfaa Jan 23, 2025
c93733b
trigger rebuild
amdfaa Jan 28, 2025
660bf97
Update unstable.yml
amdfaa Jan 30, 2025
1760efe
Update unstable.yml
amdfaa Jan 30, 2025
112ef3f
trigger rebuild
amdfaa Feb 4, 2025
786341d
Update unstable.yml
amdfaa Feb 5, 2025
df14dd8
Update unstable.yml
amdfaa Feb 5, 2025
1746600
Update unstable.yml
amdfaa Feb 11, 2025
256bc97
Update rocm-mi300.yml
amdfaa Feb 11, 2025
d22cb6a
Update rocm-mi300.yml
amdfaa Feb 11, 2025
0f28e1c
Update unstable.yml
amdfaa Feb 11, 2025
2a3c5c8
Update _rocm-test.yml
amdfaa Feb 12, 2025
e7a18a3
Update _rocm-test.yml
amdfaa Feb 17, 2025
87aa1eb
Update _rocm-test.yml
amdfaa Feb 18, 2025
c96870f
Update _rocm-test.yml
amdfaa Feb 18, 2025
204d007
Temporarily restrict number of tests to run so jobs finish quicker
jithunnair-amd Feb 18, 2025
4577243
Use GITHUB_WORKSPACE so code works on MI200 runners too
jithunnair-amd Feb 18, 2025
2ae523f
Set test-reports to UID 1001 to match runner user on MI300 host
jithunnair-amd Feb 19, 2025
144b3d0
Update _rocm-test.yml
amdfaa Feb 19, 2025
a991fbc
Conditionally change permissions only on MI300 runners
jithunnair-amd Feb 24, 2025
32422b2
Lint and syntax
jithunnair-amd Feb 25, 2025
c572335
Revert temporary diagnostic steps
jithunnair-amd Feb 26, 2025
7cecd10
Remove temp changes
jithunnair-amd Feb 26, 2025
ed14881
Remove unrelated change
jithunnair-amd Feb 26, 2025
0caccf9
Ensure that MI300 permission change step runs even on failed jobs
jithunnair-amd Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/_rocm-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,11 @@ jobs:
# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
docker exec -t "${{ env.CONTAINER_NAME }}" sh -c "cd ../pytorch && sudo cp -R test/test-reports ../workspace/test"

- name: Change permissions (only needed for MI300 runners for now)
if: ${{ always() && steps.test.conclusion && contains(matrix.runner, 'mi300') }}
run: |
docker exec -t "${{ env.CONTAINER_NAME }}" sh -c "sudo chown -R 1001:1001 test"

- name: Print remaining test logs
shell: bash
if: always() && steps.test.conclusion
Expand Down
Loading
0