Resolve zip file permission issue when uploading artifacts on ROCm MI300 CI runners #145504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145504
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 0caccf9 with merge base b63c601 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Even after removing all diagnostic steps, MI200 and MI300 runs successfully uploaded artifacts: @jeffdaily I think this PR is ready to merge. Please review and approve. EDIT: @jeffdaily pointed out that the failing shards in the MI300 run did NOT run the permission change step and hence the zipping of artifacts failed: https://github.com/pytorch/pytorch/actions/runs/13535735120/job/37827995651#step:20:120. Need some more tweaking to ensure the step runs on failed jobs too. |
jeffdaily
approved these changes
Feb 26, 2025
|
After fix in 0caccf9, we see the following, as desired:
@jeffdaily Please re-review. |
jeffdaily
approved these changes
Feb 28, 2025
|
@pytorchbot merge -f "Unrelated CI failures; confirmed that artifact uploading is working for MI300 CI jobs" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 28, 2025
Fixes #145790 Needs #145504 to be merged first to resolve an artifact uploading issue with MI300 runners. This PR moves rocm unstable MI300 back to stable. The change to unstable was introduced through this [PR](#145790). This was because the MI300s were failing with a [docker daemon](https://github.com/pytorch/pytorch/actions/runs/13015957622/job/36306779536) issue which has been resolved. Pull Request resolved: #146675 Approved by: https://github.com/jithunnair-amd, https://github.com/jeffdaily
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
…300 CI runners (pytorch#145504) E.g.: https://github.com/pytorch/pytorch/actions/runs/13500418791/job/37719437613#step:19:120 ``` Beginning upload of artifact content to blob storage Error: An error has occurred while creating the zip file for upload Error: EACCES: permission denied, open '/home/runner/_work/pytorch/pytorch/test/test-reports/backends.xeon.test_launch_1.1_22ba1133f3fcd140_.log' /home/runner/_work/_actions/actions/upload-artifact/v4/dist/upload/index.js:3459 throw new Error('An error has occurred during zip creation for the artifact'); ^ ``` Pull Request resolved: pytorch#145504 Approved by: https://github.com/jeffdaily Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
Fixes pytorch#145790 Needs pytorch#145504 to be merged first to resolve an artifact uploading issue with MI300 runners. This PR moves rocm unstable MI300 back to stable. The change to unstable was introduced through this [PR](pytorch#145790). This was because the MI300s were failing with a [docker daemon](https://github.com/pytorch/pytorch/actions/runs/13015957622/job/36306779536) issue which has been resolved. Pull Request resolved: pytorch#146675 Approved by: https://github.com/jithunnair-amd, https://github.com/jeffdaily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.: https://github.com/pytorch/pytorch/actions/runs/13500418791/job/37719437613#step:19:120
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd