8000 [ARM] Add test_memory_profiler to aarch64 tests by robert-hardwick · Pull Request #145260 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ARM] Add test_memory_profiler to aarch64 tests #145260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ARM] Add test_memory_profiler to aarch64 tests #145260

wants to merge 3 commits into from

Conversation

robert-hardwick
Copy link
Collaborator
@robert-hardwick robert-hardwick commented Jan 21, 2025 •
edited by pytorch-bot bot
Loading

@robert-hardwick robert-hardwick requested a review from a team as a code owner January 21, 2025 10:59
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145260

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 45 New Failures, 7 Cancelled Jobs, 1 Unrelated Failure

As of commit b4cb7c2 with merge base 9699cc3 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@robert-hardwick
Copy link
Collaborator Author

@malfet this should enable the test, referenced here #142366 (comment)

@robert-hardwick
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 21, 2025
@robert-hardwick robert-hardwick changed the title Add test_ops and test_memory_profiler to aarch64 tests [ARM] Add test_ops and test_memory_profiler to aarch64 tests Jan 21, 2025
@robert-hardwick robert-hardwick marked this pull request as draft January 21, 2025 14:42
@robert-hardwick robert-hardwick marked this pull request as ready for review January 21, 2025 17:28
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 23, 2025
@robert-hardwick
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased test_ops onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout test_ops && git pull --rebase)

@robert-hardwick
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@robert-hardwick @pytorchmergebot
Add test_ops and test_memory_profiler to aarch64 tests
7a40724 
- Also fixes failing test in test_memory_profiler
@pytorchmergebot
Copy link
Collaborator

Successfully rebased test_ops onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout test_ops && git pull --rebase)

@robert-hardwick
Copy link
Collaborator Author

@pytorchbot label "module: arm"

@pytorch-bot pytorch-bot bot added the module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 label Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Apr 12, 2025
@fadara01
Copy link
Collaborator

@pytorchbot label "ciflow/linux-aarch64"

@pytorch-bot pytorch-bot bot added the ciflow/linux-aarch64 linux aarch64 CI workflow label Apr 12, 2025
@fadara01 fadara01 removed Stale ciflow/linux-aarch64 linux aarch64 CI workflow labels Apr 12, 2025
@fadara01
Copy link
Collaborator

@robert-hardwick is this still needed?
I resolved the conflict and re-triggered the CI.

@malfet
Copy link
Contributor
malfet commented May 14, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/145260/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging .ci/pytorch/test.sh
CONFLICT (content): Merge conflict in .ci/pytorch/test.sh
error: could not apply 7a40724447c... Add test_ops and test_memory_profiler to aarch64 tests
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 7a40724447c... Add test_ops and test_memory_profiler to aarch64 tests

Raised by https://github.com/pytorch/pytorch/actions/runs/15022695631

@malfet malfet changed the title [ARM] Add test_ops and test_memory_profiler to aarch64 tests [ARM] Add test_memory_profiler to aarch64 tests May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

Assignees
No one assigned
Labels
module: arm Related to ARM architectures builds of PyTorch. Includes Apple M1 open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully mergin 419C g this pull request may close these issues.

Bugs in MemoryProfiler.timeline due to mix of Key and TensorKey types returned
6 participants
@robert-hardwick @pytorchmergebot @fadara01 @malfet @pytorchbot @mikaylagawarecki
0