Fix to make GELU on aarch64 preserve COW input tensor #142366
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142366
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ad69f39 with merge base f14ce3a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@robert-hardwick is it hard to enable respective test in the same PR. But looks good to me, thank you for the fix. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Not hard, but we are working on a couple more oustanding issues and then we will create a separate PR to add the tests. |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
In my experience, promise to add tests later often slips thru the cracks which opens up possibility that something could regress again |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#142365 itensor_from_tensor call was causing COW tensor to materialize Pull Request resolved: pytorch#142366 Approved by: https://github.com/malfet
Fixes #142365
itensor_from_tensor call was causing COW tensor to materialize
cc @malfet @snadampal @milpuz01