8000 [BE] Remove conda from scripts and build files Part 2 by atalman · Pull Request #145015 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE] Remove conda from scripts and build files Part 2 #145015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE] Remove conda from scripts and build files Part 2 #145015

wants to merge 2 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Jan 16, 2025 •
edited
Loading

Continuation of #144870

Remove conda logic from scripts:

  1. Remove conda build from triton build script
  2. Remove conda checks from setup.py
  3. Remove conda from release scripts
  4. Script read_conda_versions.sh is not used (checked via git grep)

Related to: #138506

@atalman atalman requested a review from a team as a code owner January 16, 2025 23:10
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 16, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145015

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 1889567 with merge base 519269a (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman changed the title Remove conda from scripts and build files Part 2 [BE] Remove conda from scripts and build files Part 2 Jan 16, 2025
@atalman
Copy link
Contributor Author
atalman commented Jan 17, 2025

@pytorchmergebot merge -f "All required signals are green, lint is not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007

Skylion007 approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @pytorchmergebot @Skylion007 @malfet
0