8000 [BE] - Remove conda test and upload scripts and env variables from Workflows Part 1 by atalman · Pull Request #144870 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[BE] - Remove conda test and upload scripts and env variables from Workflows Part 1 #144870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Jan 15, 2025

Remove conda test and upload scripts and env variables from Workflows

Related to: #138506

@atalman atalman requested a review from a team as a code owner January 15, 2025 16:46
Copy link
pytorch-bot bot commented Jan 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144870

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 36 Pending, 7 Unrelated Failures

As of commit 67c96a5 with merge base f314522 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jan 15, 2025
@atalman atalman changed the title Remove conda test and upload scripts and env variables from Workflows Remove conda test and upload scripts and env variables from Workflows Part 1 Jan 15, 2025
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted code is tested code :)

@atalman
Copy link
Contributor Author
atalman commented Jan 15, 2025

Check Binary failures are note related, but need to be fixed.

@atalman atalman changed the title Remove conda test and upload scripts and env variables from Workflows Part 1 [BE] - Remove conda test and upload scripts and env variables from Workflows Part 1 Jan 15, 2025
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jan 15, 2025
@atalman atalman force-pushed the remove_conda_metion branch from 42722d2 to 67c96a5 Compare January 16, 2025 14:36
@atalman
Copy link
Contributor Author
atalman commented Jan 16, 2025

@pytorchmergebot merge -f "xpu and executorch failures are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jan 17, 2025
Continuation of #144870

Remove conda logic from scripts:

1. Remove conda build from triton build script
2. Remove conda checks from setup.py
3. Remove conda from release scripts
4. Script read_conda_versions.sh is not used (checked via git grep)

Related to: #138506
Pull Request resolved: #145015
Approved by: https://github.com/malfet, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR Merged release notes: releng release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0