Fix poision child process issue when call getAccelerator() #144541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation fix #144152 # Solution - Align `at::globalContext()::hasXXX` to determine if accelerator XXX is built with PyTorch or an extension already registered to PyTorch. - Define `at::hasXXX` to determine if accelerator XXX is available at runtime. - Use `at::globalContext()::hasXXX` in `getAccelerator` rather than `at::hasXXX` to avoid initializing the XXX runtime (which can poison child processes) while detecting the current accelerator. Pull Request resolved: #144368 Approved by: https://github.com/albanD, https://github.com/atalman, https://github.com/gujinghui (cherry picked from commit 2583d83)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144541
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 75020ef with merge base f7e621c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
fix #144152
Solution
at::globalContext()::hasXXXto determine if accelerator XXX is built with PyTorch or an extension already registered to PyTorch.at::hasXXXto determine if accelerator XXX is available at runtime.at::globalContext()::hasXXXingetAcceleratorrather thanat::hasXXXto avoid initializing the XXX runtime (which can poison child processes) while detecting the current accelerator.cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @albanD