8000 Inductor dashboard benchmarks: swap unused freeze_autotune_cudagraphs workflow for cppwrapper workflow by benjaminglass1 · Pull Request #144427 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Inductor dashboard benchmarks: swap unused freeze_autotune_cudagraphs workflow for cppwrapper workflow #144427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

benjaminglass1
Copy link
Collaborator
@benjaminglass1 benjaminglass1 commented Jan 8, 2025

Stack from ghstack (oldest at bottom):

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input. See the HUD for an example showing that it works and displays sane output.

[ghstack-poisoned]
Copy link
pytorch-bot bot commented Jan 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144427

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit d266c50 with merge base 6bc17b0 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 8, 2025
benjaminglass1 added a commit that referenced this pull request Jan 8, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: 483fc08
Pull Request resolved: #144427
@benjaminglass1 benjaminglass1 self-assigned this Jan 8, 2025
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jan 8, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: bf98c80
Pull Request resolved: #144427
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jan 9, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: 8396bf8
Pull Request resolved: #144427
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jan 9, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: 295d86a
Pull Request resolved: #144427
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jan 9, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: b0ab6ba
Pull Request resolved: #144427
@benjaminglass1 benjaminglass1 marked this pull request as ready for review January 9, 2025 16:34
@benjaminglass1 benjaminglass1 requested a review from a team as a code owner January 9, 2025 16:34
@desertfire
Copy link
Contributor

I am surprised that your HUD link didn't show much perf gain from cpp-wrapper comparing to default, on HF and TIMM. I used to see some decent improvements there.

@benjaminglass1
Copy link
Collaborator Author

@desertfire Agreed; this is part of why I wanted to get this running, we need regular visibility into this. :)

[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jan 9, 2025
… workflow for cppwrapper workflow

GitHub limits us to 10 inputs per workflow_dispatch job, so this PR swaps out an input that is no longer used for the cppwrapper input.

ghstack-source-id: 6f16eb6
Pull Request resolved: #144427
@benjaminglass1
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/benjaminglass1/53/head branch February 12, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0