cpp_wrapper: Move #includes to per-device header files #143909
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143909
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Unrelated FailureAs of commit 0e49d4c with merge base 95b41d2 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@desertfire For your consideration: would it also be worth doing this for things built in non-cpp_wrapper AOTI mode? The precompiled header seems to be a big enough boost to make it potentially worthwhile. |
Reasonable to do something similar for AOTI |
@desertfire I think I'm going to get the |
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "breaking internal builds because of removal of torch/_inductor/codegen/aoti_runtime/implementation.cpp" -c ghfirst |
|
@desertfire Can you help with updating the internal build files as needed? |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…)" This reverts commit d62b397. Reverted #143909 on behalf of https://github.com/kit1980 due to breaking internal builds because of removal of torch/_inductor/codegen/aoti_runtime/implementation.cpp ([comment](#143909 (comment)))
|
@benjaminglass1 your PR has been successfully reverted. |
|
Hi, @benjaminglass1, I learned this PR and find some XPU code change, so I added the |
Thanks @etaf! Should I add this new file to the automatic |
I did make some internal changes to D67938955, but looks some tests were not triggered when I imported this PR. I will do another around of fix. |
|
Re-implemented in #145083 to ease internal bugfixing. |
This prepares us for the next PR in the stack, where we introduce pre-compiled per-device header files to save compilation time. ghstack-source-id: f8fd2b4 Pull Request resolved: pytorch/pytorch#143909
Summary: This prepares us for the next PR in the stack, where we introduce pre-compiled per-device header files to save compilation time. Reland #143909 after merge conflicts. Differential Revision: D68656960 Pulled By: desertfire
Summary: This prepares us for the next PR in the stack, where we introduce pre-compiled per-device header files to save compilation time. Reland #143909 after merge conflicts. Co-authored-by: Benjamin Glass <[bglass@quansight.com](mailto:bglass@quansight.com)> Differential Revision: D68656960 Pulled By: benjaminglass1 Pull Request resolved: #145932 Approved by: https://github.com/yushangdi, https://github.com/benjaminglass1 Co-authored-by: bglass@quansight.com <bglass@quansight.com>
Stack from ghstack (oldest at bottom):
This prepares us for the next PR in the stack, where we introduce pre-compiled per-device header files to save compilation time.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
Differential Revision: D67938955