8000 [ONNX] Update images and APIs to onnx_dynamo.rst by titaiwangms · Pull Request #144358 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ONNX] Update images and APIs to onnx_dynamo.rst #144358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[ONNX] Update images and APIs to onnx_dynamo.rst #144358

wants to merge 4 commits into from

Conversation

titaiwangms
Copy link
Collaborator

Update the result image of exporting, and delete the functions/class that belongs to torch.onnx.dynamo_export

@titaiwangms titaiwangms added the module: onnx Related to torch.onnx label Jan 8, 2025
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 8, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144358

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5b1f5f2 with merge base e14c36d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 8, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@titaiwangms titaiwangms added topic: docs topic category and removed merging topic: docs topic category labels Jan 8, 2025
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@justinchuby justinchuby added this to the 2.6.0 milestone Jan 8, 2025
@justinchuby
Copy link
Collaborator

@titaiwangms you may want to cherry pick this change

@titaiwangms titaiwangms added suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category labels Jan 8, 2025
@justinchuby justinchuby added topic: docs topic category and removed topic: bc breaking topic category labels Jan 8, 2025
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • Documentation (svekars)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@titaiwangms
Copy link
Collaborator Author

@malfet @kit1980 can you help us merge this piece of documentation for onnx? we updated references in main doc which requires your approval

malfet
malfet approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@malfet
Copy link
Contributor
malfet commented Jan 8, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@titaiwangms
Copy link
Collaborator Author

@pytorchbot cherry-pick --onto release/2.6 -c docs

pytorchbot pushed a commit that referenced this pull request Jan 8, 2025
@titaiwangms @pytorchbot
[ONNX] Update images and APIs to onnx_dynamo.rst (#144358)
18eb233 
Update the result image of exporting, and delete the functions/class that belongs to `torch.onnx.dynamo_export`
Pull Request resolved: #144358
Approved by: https://github.com/justinchuby, https://github.com/malfet

(cherry picked from commit a742859)
@pytorchbot
Copy link
Collaborator

Cherry picking #144358

The cherry pick PR is at #144428 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jan 8, 2025
Closed
kit1980 pushed a commit that referenced this pull request Jan 10, 2025
@pytorchbot @titaiwangms
[ONNX] Update images and APIs to onnx_dynamo.rst (#144428)
47f4e56 
[ONNX] Update images and APIs to onnx_dynamo.rst (#144358)

Update the result image of exporting, and delete the functions/class that belongs to `torch.onnx.dynamo_export`
Pull Request resolved: #144358
Approved by: https://github.com/justinchuby, https://github.com/malfet

(cherry picked from commit a742859)

Co-authored-by: titaiwangms <titaiwang@microsoft.com>
@atalman atalman mentioned this pull request Jan 13, 2025
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: docs topic category
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@titaiwangms @pytorchmergebot @justinchuby @malfet @pytorchbot
0