Use Manylinux 2.28 for nightly build and cxx11-abi #143423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143423
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 5 Cancelled Jobs, 2 Unrelated FailuresAs of commit 3d99c93 with merge base 7c25a55 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
8000
commented
Dec 17, 2024
| @@ -126,7 +126,7 @@ jobs: | |||
| # favor of GPU_ARCH_VERSION | |||
| DESIRED_CUDA: cpu | |||
| GPU_ARCH_TYPE: cpu | |||
| DOCKER_IMAGE: pytorch/manylinux-builder:cpu-main | |||
| DOCKER_IMAGE: pytorch/manylinux2_28-builder:cpu-main | |||
There was a problem hiding this comment.
Please note, this is not used on MacOS arm64. TODO: Post a followup to remove this parameter
5 tasks
huydhn
approved these changes
Dec 17, 2024
|
cc @q10 I think this would help with the various issues on FBGEMM once we have a new PT nightly after this lands |
malfet
approved these changes
Dec 17, 2024
seemethere
approved these changes
Dec 17, 2024
|
@pytorchmergebot merge -f "lint and required builds are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Dec 18, 2024
Switch nightly ecosystem Wheel Builds to manylinux 2.28 pytorch/pytorch PR: pytorch/pytorch#143423
aditew01
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Dec 18, 2024
As per: https://dev-discuss.pytorch.org/t/pytorch-linux-wheels-switching-to-new-wheel-build-platform-manylinux-2-28-on-november-12-2024/2581 Linux Builds: CPU, CUDA 11.8, CUDA 12.4 switched to Manylinux 2.28 and D_GLIBCXX_USE_CXX11_ABI=1 on the week of Dec 16 Pull Request resolved: pytorch#143423 Approved by: https://github.com/huydhn, https://github.com/malfet, https://github.com/seemethere
8000
facebook-github-bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Dec 26, 2024
Summary: X-link: facebookresearch/FBGEMM#612 This reverts commit 5c16f4b. This is not needed anymore after pytorch/pytorch#143423. I think this will also fix the issue with building torchrec CPU https://github.com/pytorch/FBGEMM/actions/runs/12470608879/job/34806045264?pr=3528#step:18:219 ### Testing https://github.com/pytorch/FBGEMM/actions/runs/12470608879 Pull Request resolved: #3528 Reviewed By: q10 Differential Revision: D67602736 Pulled By: huydhn fbshipit-source-id: ec5888acacd96295dd6dfe26e5fa87b28810b2bc
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#612 This reverts commit 5c16f4b. This is not needed anymore after pytorch/pytorch#143423. I think this will also fix the issue with building torchrec CPU https://github.com/pytorch/FBGEMM/actions/runs/12470608879/job/34806045264?pr=3528#step:18:219 ### Testing https://github.com/pytorch/FBGEMM/actions/runs/12470608879 X-link: pytorch#3528 Reviewed By: q10 Differential Revision: D67602736 Pulled By: huydhn fbshipit-source-id: ec5888acacd96295dd6dfe26e5fa87b28810b2bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per: https://dev-discuss.pytorch.org/t/pytorch-linux-wheels-switching-to-new-wheel-build-platform-manylinux-2-28-on-november-12-2024/2581
Linux Builds: CPU, CUDA 11.8, CUDA 12.4 switched to Manylinux 2.28 and D_GLIBCXX_USE_CXX11_ABI=1 on the week of Dec 16