Attempt to fix FBGEMM CPU build #3499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
q10
approved these changes
Dec 11, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 26, 2024
Summary: X-link: facebookresearch/FBGEMM#612 This reverts commit 5c16f4b. This is not needed anymore after pytorch/pytorch#143423. I think this will also fix the issue with building torchrec CPU https://github.com/pytorch/FBGEMM/actions/runs/12470608879/job/34806045264?pr=3528#step:18:219 ### Testing https://github.com/pytorch/FBGEMM/actions/runs/12470608879 Pull Request resolved: #3528 Reviewed By: q10 Differential Revision: D67602736 Pulled By: huydhn fbshipit-source-id: ec5888acacd96295dd6dfe26e5fa87b28810b2bc
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#578 Attempt to fix https://github.com/pytorch/FBGEMM/actions/runs/12209285300/job/34063862021 before we have the new manywheel 2.28 container with the new toolchain available. ### Testing Looks ok now https://github.com/pytorch/FBGEMM/actions/runs/12283462291 X-link: pytorch#3499 Reviewed By: q10 Differential Revision: D67110022 Pulled By: huydhn fbshipit-source-id: 74ff8c19565d24c7c1d7074190fff2c305dcaa33
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#612 This reverts commit 5c16f4b. This is not needed anymore after pytorch/pytorch#143423. I think this will also fix the issue with building torchrec CPU https://github.com/pytorch/FBGEMM/actions/runs/12470608879/job/34806045264?pr=3528#step:18:219 ### Testing https://github.com/pytorch/FBGEMM/actions/runs/12470608879 X-link: pytorch#3528 Reviewed By: q10 Differential Revision: D67602736 Pulled By: huydhn fbshipit-source-id: ec5888acacd96295dd6dfe26e5fa87b28810b2bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix https://github.com/pytorch/FBGEMM/actions/runs/12209285300/job/34063862021 before we have the new manywheel 2.28 container with the new toolchain available.
Testing
Looks ok now https://github.com/pytorch/FBGEMM/actions/runs/12283462291