[MPS] Support torch.accelerator.synchronize() on mps #143171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143171
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 956dcd9 with merge base cf538ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 13, 2024
|
@malfet, may I know if this code change is reasonable for you? |
Thanks very much~ |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 16, 2024
# Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in #142468. The previous commit is 952514f Pull Request resolved: #133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: #143171
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Dec 16, 2024
…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#143171, pytorch#133572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
Support
torch.accelerator.synchronize()on mps. The root cause is that MPS doesn't support lazy initialization. So we must check if the current accelerator supports device lazy initialization rather than early return.Additional Context
Add a mps UT to test code change.