[RELAND] Add UTs for accelerator device-agnostic runtime APIs #133572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133572
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ac1aefd with merge base cf538ef ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
requested changes
Sep 25, 2024
| self.assertEqual(torch.current_accelerator(), "xpu") | ||
|
|
||
| @unittest.skipIf(not TEST_ACCELERATOR, "no avaliable accelerators detected") | ||
| def test_generic_multi_device_behavior(self): |
There was a problem hiding this comment.
Please add device to the input parameter. So that you can check if the current device type is the same as the input device type.
There was a problem hiding this comment.
Refine the UTs to be more general.
|
@pytorchbot revert -m 'Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore' -c nosignal test_accelerator.py::TestAccelerator::test_generic_stream_behavior GH job link HUD commit link |
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Dec 11, 2024
…138677)" This reverts commit 734bb01. Reverted #138677 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](#133572 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Dec 11, 2024
…#133572)" This reverts commit 2091194. Reverted #133572 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](#133572 (comment)))
|
@guangyey your PR has been successfully reverted. |
kit1980
added a commit
that referenced
this pull request
Dec 12, 2024
* Revert "[RELAND] Add device-agnostic runtime Device/Stream C++ API (#138677)" This reverts commit 734bb01. Reverted #138677 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](#133572 (comment))) * Revert "[RELAND] Add UTs for accelerator device-agnostic runtime APIs (#133572)" This reverts commit 2091194. Reverted #133572 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](#133572 (comment))) --------- Co-authored-by: PyTorch MergeBot <pytorchmergebot@users.noreply.github.com>
This was referenced Dec 13, 2024
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…8677)" This reverts commit f84e533. Reverted pytorch#138677 on behalf of https://github.com/malfet due to Sorry for reverting your PR, but it segfaults on MacOS ([comment](pytorch#133572 (comment)))
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…#133572)" This reverts commit 952514f. Reverted pytorch#133572 on behalf of https://github.com/malfet due to Sorry for reverting your PR, but it segfaults on MacOS ([comment](pytorch#133572 (comment)))
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…h#133572) # Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@952514f Pull Request resolved: pytorch#133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: pytorch#142468
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#142468, pytorch#133572
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…dx => index}` (pytorch#140542)" This reverts commit fb02b40. Reverted pytorch#140542 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but I need to revert this in order to revert pytorch#133572 (comment) due to a conflict ([comment](pytorch#140542 (comment)))
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…ytorch#138677)" This reverts commit 734bb01. Reverted pytorch#138677 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](pytorch#133572 (comment)))
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
…pytorch#133572)" This reverts commit 2091194. Reverted pytorch#133572 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is still very flaky on MacOS even when it does not segfault anymore ([comment](pytorch#133572 (comment)))
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Dec 16, 2024
…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#143171, pytorch#133572
aditew01
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Dec 18, 2024
…h#133572) # Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@952514f Pull Request resolved: pytorch#133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: pytorch#143171
aditew01
pushed a commit
to aditew01/pytorch
that referenced
this pull request
Dec 18, 2024
…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#143171, pytorch#133572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
This PR intends to add UTs for accelerator device-agnostic APIs.
Additional Context
This PR is relanded. It is reverted because
torch.Eventdoesn't support mps backend. We have fixed it in #142468. The previous commit is 952514fcc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10