8000 temporarily turn on keep-going/continue on error for mac by clee2000 · Pull Request #142421 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

temporarily turn on keep-going/continue on error for mac #142421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

clee2000
Copy link
Contributor
@clee2000 clee2000 commented Dec 9, 2024

See #142270 for additional info.

Make all mac default shard tests run with keep going / continue on error so we can see all the test failures.

Red signal will show up later, but you can see failing tests mid run on HUD by clicking the additional test failures button

After the job is finished, searching for "consistently: " in the logs will find the failed tests

Copy link
pytorch-bot bot commented Dec 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142421

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit c92685e with merge base 8d24eb0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 added the topic: not user facing topic category label Dec 9, 2024
@clee2000 clee2000 marked this pull request as ready for review December 9, 2024 22:52
@clee2000 clee2000 requested a review from a team as a code owner December 9, 2024 22:52
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@clee2000 clee2000 added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2024
@clee2000
Copy link
Contributor Author
clee2000 commented Dec 9, 2024

@pytorchbot merge -f "mac testing is going, at worst this is a noop"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

10000
@malfet
Copy link
Contributor
malfet commented Dec 10, 2024

I wonder if it's better to revert it after getting a signal on few PRs

@malfet
Copy link
Contributor
malfet commented Dec 10, 2024

@pytorchbot revert -m "We've collected enough info for now" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@clee2000 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 10, 2024
…2421)"

This reverts commit 17202ea.

Reverted #142421 on behalf of https://github.com/malfet due to We've collected enough info for now ([comment](#142421 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 10, 2024
@clee2000 clee2000 closed this Dec 10, 2024
@github-actions github-actions bot deleted the csl/mac_keep_going_always branch January 11, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0