-
Notifications
You must be signed in to change notification settings - Fork 24.7k
temporarily turn on keep-going/continue on error for mac #142421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142421
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit c92685e with merge base 8d24eb0 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@pytorchbot merge -f "mac testing is going, at worst this is a noop" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
I wonder if it's better to revert it after getting a signal on few PRs |
@pytorchbot revert -m "We've collected enough info for now" -c weird |
@pytorchbot successfully started a revert job. Check the current status here. |
@clee2000 your PR has been successfully reverted. |
…2421)" This reverts commit 17202ea. Reverted #142421 on behalf of https://github.com/malfet due to We've collected enough info for now ([comment](#142421 (comment)))
See #142270 for additional info.
Make all mac default shard tests run with keep going / continue on error so we can see all the test failures.
Red signal will show up later, but you can see failing tests mid run on HUD by clicking the additional test failures button
After the job is finished, searching for "consistently: " in the logs will find the failed tests