[Do not revert] Re-enable Mac testing #142270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142270
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 544e7cc with merge base cca33d5 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
✅ Deploy Preview for chimerical-cranachan-793287 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
malfet
approved these changes
Dec 9, 2024
seemethere
approved these changes
Dec 9, 2024
atalman
approved these changes
Dec 9, 2024
malfet
reviewed
Dec 9, 2024
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
c248e83 to
0b1f601
Compare
malfet
reviewed
Dec 9, 2024
|
@pytorchbot merge -f "Re-enable testing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Dec 9, 2024
Closed
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
See #142270 for additional info. Make all mac default shard tests run with keep going / continue on error so we can see all the test failures. Red signal will show up later, but you can see failing tests mid run on HUD by clicking the additional test failures button After the job is finished, searching for "consistently: " in the logs will find the failed tests Pull Request resolved: #142421 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Dec 11, 2024
The bash script modification in pytorch#135386 results in tests on mac in default shard not running. This PR is expected to cause test failures, but we need to start getting signal, so landing with known failures Pull Request resolved: pytorch#142270 Approved by: https://github.com/malfet, https://github.com/seemethere, https://github.com/atalman Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Dec 11, 2024
) See pytorch#142270 for additional info. Make all mac default shard tests run with keep going / continue on error so we can see all the test failures. Red signal will show up later, but you can see failing tests mid run on HUD by clicking the additional test failures button After the job is finished, searching for "consistently: " in the logs will find the failed tests Pull Request resolved: pytorch#142421 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
The bash script modification in pytorch#135386 results in tests on mac in default shard not running. This PR is expected to cause test failures, but we need to start getting signal, so landing with known failures Pull Request resolved: pytorch#142270 Approved by: https://github.com/malfet, https://github.com/seemethere, https://github.com/atalman Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
) See pytorch#142270 for additional info. Make all mac default shard tests run with keep going / continue on error so we can see all the test failures. Red signal will show up later, but you can see failing tests mid run on HUD by clicking the additional test failures button After the job is finished, searching for "consistently: " in the logs will find the failed tests Pull Request resolved: pytorch#142421 Approved by: https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bash script modification in #135386 results in tests on mac in default shard not running.
This PR is expected to cause test failures, but we need to start getting signal, so landing with known failures
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov