8000 [FX][export][dynamo] use `tuple` instead of `list` in normalized `args_spec` by XuehaiPan · Pull Request #138212 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[FX][export][dynamo] use tuple instead of list in normalized args_spec #138212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[FX][export][dynamo] use tuple instead of list in normalized args_spec #138212

wants to merge 19 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Oct 17, 2024 •
edited by pytorch-bot bot
Loading

@XuehaiPan
Update
84558f4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138212

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9ebe3f7 with merge base dbd6ada (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: inductor release notes: onnx torch.onnx related changes that should show up in the release notes labels Oct 17, 2024
This was referenced Oct 17, 2024
Closed
Open
Open
Closed
@XuehaiPan
Update
4698d83 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
f4ba586 
…s_spec`

ghstack-source-id: 188c748
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
5d12dd8 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
f43f638 
…s_spec`

ghstack-source-id: c29bfac
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
1a41405 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
607a1a1 
…s_spec`

ghstack-source-id: a6c407b
Pull Request resolved: pytorch#138
8000
212
@XuehaiPan
Update
4913863 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
f24e532 
…s_spec`

ghstack-source-id: f9552dd
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
ce24fab 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
4476b33 
…s_spec`

ghstack-source-id: db2af89
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
ea4ae55 
[ghstack-poisoned]
@XuehaiPan
Update
f804769 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
705e535 
…s_spec`

ghstack-source-id: 9a4d8fb
Pull Request resolved: pytorch#138212
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 17, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
cab413f 
…s_spec`

ghstack-source-id: 9a4d8fb
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
4061860 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 22, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
b32bdb8 
…s_spec`

ghstack-source-id: 6240ec9
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
ff1396a 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 22, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
2845f4d 
…s_spec`

ghstack-source-id: ea83d16
Pull Request resolved: pytorch#138212
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 22, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
d518e5c 
…s_spec`

ghstack-source-id: ea83d16
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
8d59782 
[ghstack-poisoned]
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2024
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
62b6d61 
…s_spec`

ghstack-source-id: d9e44df
Pull Request resolved: pytorch#138212
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan
Update
186b5cf 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
9631280 
…s_spec`

ghstack-source-id: c57b279
Pull Request resolved: pytorch#138212
@XuehaiPan
Update
9ebe3f7 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 24, 2024
@XuehaiPan
[FX][export][dynamo] use tuple instead of list in normalized `arg…
d753719 
…s_spec`

ghstack-source-id: a9731c1
Pull Request resolved: pytorch#138212
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "stuck at macOS CI queue"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/187/head branch November 25, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel jansel approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@justinchuby justinchuby Awaiting requested review from justinchuby

@wschin wschin Awaiting requested review from wschin

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: export release notes: fx release notes category release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @pytorchmergebot @jansel @pytorchbot
0