[pytree] support PyStructSequence types for Python pytree #113258
+110
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113258
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 797bb0f with merge base cb5f31a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 8, 2023
[ghstack-poisoned]
cc zou3519 [ghstack-poisoned]
XuehaiPan
commented
Nov 8, 2023
XuehaiPan
commented
Nov 8, 2023
cc zou3519 [ghstack-poisoned]
XuehaiPan
commented
Nov 8, 2023
|
I don't really have any context for the work here; @zou3519 are you taking care of it? |
@ezyang The context is to make Python pytree and C++ pytree utilities provide unified APIs. This would make users switching between these two implementations much easier.
I figured out why the Dynamo tests failed and updated the PR. See my comment in #113258 (comment) and #113258 (comment). Sorry for the pin noise @ezyang. |
Yeah I got it |
cc zou3519 [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 2, 2025
ghstack-source-id: fcf711e Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 2, 2025
ghstack-source-id: d69d3ee Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 2, 2025
ghstack-source-id: f1a5447 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 3, 2025
ghstack-source-id: ad5bdb5 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 5, 2025
ghstack-source-id: d9cf12d Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 7, 2025
ghstack-source-id: d50577d Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 23, 2025
ghstack-source-id: 35ad83a Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Apr 26, 2025
ghstack-source-id: c2d73b2 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 1, 2025
ghstack-source-id: 8c124ba Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 5, 2025
ghstack-source-id: 5c81c94 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 8, 2025
ghstack-source-id: f200745 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 11, 2025
ghstack-source-id: f200745 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 14, 2025
ghstack-source-id: 4b702d6 Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 14, 2025
ghstack-source-id: 154648e Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 16, 2025
ghstack-source-id: 154648e Pull Request resolved: pytorch#113258
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
May 16, 2025
ghstack-source-id: 069d065 Pull Request resolved: pytorch#113258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
treespec_{leaf,tuple,dict}functions for args_spec modification #138214cc @zou3519