xpu: fix 3rd party builds on systems with cmake<3.25 #135767
Conversation
Fixes: pytorch#135766 Cmake LINUX variable is available on starting from cmake 3.25. Better to use CMAKE_SYSTEM_NAME instead to relax cmake version requirement. See: https://cmake.org/cmake/help/v3.25/variable/LINUX.html Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135767
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 46e2bf2 with merge base 9a04cfb ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-py3.9 / test (default, 4, 4, linux.idc.xpu) Details for Dev Infra teamRaised by workflow job |
|
Unrelated failure. |
Merge startedYour change will be merged while ignoring the following 1 checks: xpu / linux-jammy-xpu-py3.9 / test (default, 4, 4, linux.idc.xpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Cmake LINUX variable is available on starting from cmake 3.25. Better to use CMAKE_SYSTEM_NAME instead to relax cmake version requirement. See: https://cmake.org/cmake/help/v3.25/variable/LINUX.html Fixes: pytorch#135766 Pull Request resolved: pytorch#135767 Approved by: https://github.com/malfet, https://github.com/guangyey
|
@pytorchbot cherry-pick --onto release/2.5 -c critical |
Cmake LINUX variable is available on starting from cmake 3.25. Better to use CMAKE_SYSTEM_NAME instead to relax cmake version requirement. See: https://cmake.org/cmake/help/v3.25/variable/LINUX.html Fixes: #135766 Pull Request resolved: #135767 Approved by: https://github.com/malfet, https://github.com/guangyey (cherry picked from commit 9852c6d)
Cherry picking #135767The cherry pick PR is at #138668 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Cmake LINUX variable is available on starting from cmake 3.25. Better to use CMAKE_SYSTEM_NAME instead to relax cmake version requirement.
See: https://cmake.org/cmake/help/v3.25/variable/LINUX.html
Fixes: #135766