8000 Do not import transformers when import torch._dynamo by soulitzer · Pull Request #124634 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Do not import transformers when import torch._dynamo #124634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Do not import transformers when import torch._dynamo #124634

wants to merge 3 commits into from

Conversation

soulitzer
Copy link
Contributor
@soulitzer soulitzer commented Apr 22, 2024 •
edited
Loading

@soulitzer soulitzer mentioned this pull request Apr 22, 2024
Draft
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124634

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27d40a8 with merge base bad8d25 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 22, 2024
@thiagocrepaldi thiagocrepaldi added module: onnx Related to torch.onnx onnx-triaged triaged by ONNX team topic: not user facing topic category labels Apr 22, 2024
@soulitzer soulitzer added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category release notes: dynamo labels Apr 22, 2024
@xuzhao9
Copy link
Contributor
xuzhao9 commented Apr 22, 2024

huggingface/safetensors#318 has been merged, maybe this check can be skipped at all?

@soulitzer soulitzer removed the topic: not user facing topic category label Apr 22, 2024
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang ezyang added this to the 2.3.1 milestone Apr 23, 2024
@ezyang
Copy link
Contributor
ezyang commented Apr 23, 2024

please submit cherry pick to 2.3 branch

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@soulitzer @petrex
Do not import transformers when import torch._dynamo (pytorch#124634)
31bb9d1 
Fixes pytorch#123954

Pull Request resolved: pytorch#124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: pytorch#124343
soulitzer added a commit that referenced this pull request May 8, 2024
@soulitzer
Do not import transformers when import torch._dynamo (#124634)
ec3ae77 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
This was referenced May 8, 2024
Merged
Closed
atalman pushed a commit that referenced this pull request May 15, 2024
@soulitzer
Do not import transformers when import torch._dynamo (#124634) (#125755)
be9a407 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
@github-actions github-actions bot deleted the gh/soulitzer/297/head branch June 2, 2024 02:02
desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@soulitzer
Do not import transformers when import torch._dynamo
b5400b8 
ghstack-source-id: 7a35da7
Pull Request resolved: pytorch/pytorch#124634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagocrepaldi thiagocrepaldi thiagocrepaldi approved these changes

@Chillee Chillee Chillee approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

@wschin wschin Awaiting requested review from wschin

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx onnx-triaged triaged by ONNX team release notes: dynamo release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@soulitzer @xuzhao9 @pytorchmergebot @ezyang @thiagocrepaldi @Chillee
0