8000 [NJT] Inline through torch.nested.nested_tensor_from_jagged instead of graph break by soulitzer · Pull Request #124343 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[NJT] Inline through torch.nested.nested_tensor_from_jagged instead of graph break #124343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[NJT] Inline through torch.nested.nested_tensor_from_jagged instead of graph break #124343

wants to merge 4 commits into from

Conversation

soulitzer
Copy link
Contributor
@soulitzer soulitzer commented Apr 17, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124343

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit 53d8ecf with merge base bad8d25 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer requested a review from jbschlosser April 18, 2024 00:01
jbschlosser
jbschlosser approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor
@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@soulitzer
Update on "[NJT] Inline through torch.nested.nested_tensor_from_jagge…
2200987 
…d instead of graph break"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang

[ghstack-poisoned]
soulitzer added a commit that referenced this pull request Apr 18, 2024
@soulitzer
[NJT] Inline through torch.nested.nested_tensor_from_jagged instead o…
8e81b66 
…f graph break

ghstack-source-id: be33590
Pull Request resolved: #124343
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jbschlosser jbschlosser added the topic: not user facing topic category label Apr 18, 2024
@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2)

Details for Dev Infra team Raised by workflow job

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / rocm6.0-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@DanilBaibak
Copy link
Contributor

@pytorchbot revert -m "Broken trunk" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@soulitzer your PR has been successfully reverted.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 6 checks: pull / linux-focal-py3.12-clang10 / test (default, 3, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, linux.2xlarge), pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, linux.4xlarge), trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge), trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@soulitzer
[NJT] Inline through torch.nested.nested_tensor_from_jagged instead o…
2d6403f 
…f graph break (#124343)

Pull Request resolved: #124343
Approved by: https://github.com/jbschlosser
8000
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@pytorchmergebot
Revert "[NJT] Inline through torch.nested.nested_tensor_from_jagged i…
dea2fdf 
…nstead of graph break (#124343)"

This reverts commit ef93402.

Reverted #124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](#124343 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@soulitzer
[NJT] Inline through torch.nested.nested_tensor_from_jagged instead o…
84656cd 
…f graph break (#124343)

Pull Request resolved: #124343
Approved by: https://github.com/jbschlosser
This was referenced Apr 22, 2024
Draft
Closed
pytorchmergebot pushed a commit that referenced this pull request Apr 23, 2024
@soulitzer @pytorchmergebot
Do not import transformers when import torch._dynamo (#124634)
1fcdea8 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@soulitzer @petrex
[NJT] Inline through torch.nested.nested_tensor_from_jagged instead o…
93f4539 
…f graph break (pytorch#124343)

Pull Request resolved: pytorch#124343
Approved by: https://github.com/jbschlosser
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@pytorchmergebot @petrex
Revert "[NJT] Inline through torch.nested.nested_tensor_from_jagged i…
6D40
f927e37 
…nstead of graph break (pytorch#124343)"

This reverts commit ef93402.

Reverted pytorch#124343 on behalf of https://github.com/DanilBaibak due to Broken trunk ([comment](pytorch#124343 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@soulitzer @petrex
[NJT] Inline through torch.nested.nested_tensor_from_jagged instead o…
556216e 
…f graph break (#124343)

Pull Request resolved: #124343
Approved by: https://github.com/jbschlosser
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@soulitzer @petrex
Do not import transformers when import torch._dynamo (#124634)
31bb9d1 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
soulitzer added a commit that referenced this pull request May 8, 2024
@soulitzer
Do not import transformers when import torch._dynamo (#124634)
ec3ae77 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
@soulitzer soulitzer mentioned this pull request May 8, 2024
Merged
atalman pushed a commit that referenced this pull request May 15, 2024
@soulitzer
Do not import transformers when import torch._dynamo (#124634) (#125755)
be9a407 
Fixes #123954

Pull Request resolved: #124634
Approved by: https://github.com/thiagocrepaldi, https://github.com/Chillee
ghstack dependencies: #124343
@github-actions github-actions bot deleted the gh/soulitzer/294/head branch June 2, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 left review comments

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soulitzer @pytorchmergebot @jbschlosser @DanilBaibak @davidberard98
0