8000 [inductor] Fix MKL issue with test_indirect_device_assert by jansel · Pull Request #108172 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[inductor] Fix MKL issue with test_indirect_device_assert #108172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

@pytorch-bot
Copy link
pytorch-bot bot commented Aug 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108172

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2f9df0f with merge base fe1f26a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel requested a review from peterbell10 August 29, 2023 18:20
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]
@@ -7543,6 +7544,7 @@ def fn(x: torch.Tensor) -> torch.Tensor:
fn_opt(inps)

@skipIfRocm
@skip_if_consumer_card
Copy link
Collaborator
@peterbell10 peterbell10 Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test works for me on a 2060. What issues are you seeing on a 3090?

Copy link
Contributor Author
@jansel jansel Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subprocess is failing with:

b'Error: mkl-service + Intel(R) MKL: MKL_THREADING_LAYER=INTEL is incompatible with libgomp.so.1 library.\n\tTry to import numpy first or set the threading layer accordingly. Set MKL_SERVICE_FORCE_INTEL to force it.\n'

Actually might not be related to consumer cards, that was a guess based on test names and it only failing on my desktop not CI. I think I can fix it with MKL_THREADING_LAYER=GNU.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like #37377 which should be fixed by updating mkl-service. Your workaround seems fine though.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]
@jansel jansel changed the title [inductor] Skip test_indirect_device_assert on RTX3090 [inductor] Fix MKL issue with test_indirect_device_assert Aug 29, 2023
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 29, 2023
@jansel jansel requested a review from peterbell10 August 29, 2023 22:18
@jansel
Copy link
Contributor Author
jansel commented Aug 30, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 30, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all chec 8000 ks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@jansel
Copy link
Contributor Author
jansel commented Aug 30, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov anijain2305

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jansel/170/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/108172)

pytorchmergebot pushed a commit that referenced this pull request Aug 30, 2023
@jansel
Copy link
Contributor Author
jansel commented Aug 30, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/jansel/170/head branch September 3, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0