8000 CI: Run tests on Windows by effigies · Pull Request #263 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

CI: Run tests on Windows #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

CI: Run tests on Windows #263

wants to merge 3 commits into from

Conversation

effigies
Copy link
Contributor
@effigies effigies commented Aug 25, 2021 •
edited
Loading

Inspired by #262. Let's see if we can get tests going on Windows.

@effigies effigies force-pushed the ci/windows branch 3 times, most recently from f169245 to ffe90c9 Compare August 25, 2021 18:43
@DancingQuanta DancingQuanta mentioned this pull request Aug 25, 2021
Merged
@DancingQuanta
Copy link
Contributor

I have spent some time reading through the tests, and it appears that the virtualenv setup is the first issue to tackle in testing suite. The virtualenv invocation is only designed for Linux, and so I need to understand what this step actually do.
One indication is the paths used. These paths need to be adapted to windows' style paths.
One way to do this is to create another class from _Invocations and use windows path in methods or other way of using paths.
I am not experienced in automating creation of virtualenvs and so this will take me some time to work out what is the right step forwards.

@DancingQuanta
Copy link
Contributor

Ca I have advice on _Invocation please? Is this class the original product of python-versioneer? Or was this class inspired by other projects? If there are many projects using similar techniques, there might to be one with a solution for Windows.

8000

@effigies
Copy link
Contributor Author

As far as I know, it was originally written for Versioneer. I haven't seen anything like it elsewhere.

@mathijsvdv mathijsvdv mentioned this pull request Jan 31, 2022
Closed
This was referenced Feb 9, 2022
Closed
Merged
@effigies
Copy link
Contributor Author

Closing in favor of #283.

@effigies effigies closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effigies @DancingQuanta
0