8000 `test_dist` and `test_dist_subproject` failing · Issue #282 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

test_dist and test_dist_subproject failing #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mathijsvdv opened this issue Feb 9, 2022 · 2 comments
Closed

test_dist and test_dist_subproject failing #282

mathijsvdv opened this issue Feb 9, 2022 · 2 comments

Comments

@mathijsvdv
Copy link
Contributor

I am currently working on implementing a fix to #273 and #263. Performing the first run of the tox.yml workflow I noticed that two tests are currently failing in the master branch:

  • git/test_invocations.py::DistutilsRepo::test_sdist
  • git/test_invocations.py::DistutilsRepo::test_sdist_subproject

The error is the same in each case: I find that

"demoapp2-2.0/src/demoapp2.egg-info/PKG-INFO" in t.getnames()

actually holds true, whereas it should be false. Namely the t.getnames() evaluates to the following list:

[
    'demoapp2-2.0',
    'demoapp2-2.0/MANIFEST.in',
    'demoapp2-2.0/PKG-INFO',
    'demoapp2-2.0/README',
    'demoapp2-2.0/bin',
    'demoapp2-2.0/bin/rundemo',
    'demoapp2-2.0/setup.cfg',
    'demoapp2-2.0/setup.py',
    'demoapp2-2.0/src',
    'demoapp2-2.0/src/demo',
    'demoapp2-2.0/src/demo/__init__.py',
    'demoapp2-2.0/src/demo/_version.py',
    'demoapp2-2.0/src/demoapp2.egg-info',
    'demoapp2-2.0/src/demoapp2.egg-info/PKG-INFO',
    'demoapp2-2.0/src/demoapp2.egg-info/SOURCES.txt',
    'demoapp2-2.0/src/demoapp2.egg-info/dependency_links.txt',
    'demoapp2-2.0/src/demoapp2.egg-info/top_level.txt',
    'demoapp2-2.0/versioneer.py'
]

What could have caused this?
@effigies
Copy link
Contributor
effigies commented Feb 9, 2022

Distutils is being deprecated. Feel free to disable any distutils-related tests.

@mathijsvdv
Copy link
Contributor Author

Will do, thanks for the quick confirmation.

mathijsvdv added a commit to mathijsvdv/python-versioneer that referenced this issue Feb 13, 2022
@mathijsvdv
Remove test_sdist and test_sdist_subproject from the `DistutilsRe…
4875183 
…po` test case.

Closes python-versioneer#282
@mathijsvdv mathijsvdv mentioned this issue Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@effigies @mathijsvdv
0