FIX: Escape asterisk in git describe call on Windows
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can work on these tests. Thanks for pointing them out.
I will find some time this week.
…On Wed, 25 Aug 2021, 18:58 Chris Markiewicz, ***@***.***> wrote:
***@***.**** approved this pull request.
Overall looks reasonable. I opened #263
<#263> to
enable tests on Windows. Since it seems you have a Windows box, is there
any chance you could go through and fix the tests up?
------------------------------
In src/git/from_vcs.py
<#262 (comment)>
:
> if sys.platform == "win32":
GITS = ["git.cmd", "git.exe"]
+ TAG_PREFIX_REGEX = "\*"
⬇️ Suggested change
- TAG_PREFIX_REGEX = "\*"
+ TAG_PREFIX_REGEX = "\\*"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#262 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAHOVKBHJT4N4TR25TPOL3T6UVNBANCNFSM5CVFVT4Q>
.
|
effigies
reviewed
Aug 31, 2021
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
git describe call on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a fix for #122.
This fix makes use of an existing check for
win32to modifies the argument to--matchaccordingly so that the*is escaped for Windows users.