8000 Don't reference class attributes as class attributes within methods. by WeatherGod · Pull Request #37 · python-metar/python-metar · GitHub
[go: up one dir, main page]
Skip to content

Don't reference class attributes as class attributes within methods. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akrherz merged 1 commit into from
Jul 22, 2018
Merged

Don't reference class attributes as class attributes within methods. #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions metar/Metar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,11 @@ def __init__( self, metarcode, month=None, year=None, utcdelta=None):

code = self.code+" " # (the regexps all expect trailing spaces...)
try:
ngroup = len(Metar.handlers)
ngroup = len(self.handlers)
igroup = 0
ifailed = -1
while igroup < ngroup and code:
pattern, handler, repeatable = Metar.handlers[igroup]
pattern, handler, repeatable = self.handlers[igroup]
if debug: print(handler.__name__,":",code)
m = pattern.match(code)
while m:
Expand Down Expand Up @@ -393,7 +393,7 @@ def __init__( self, metarcode, month=None, year=None, utcdelta=None):
# groups, we'll try parsing this group as a remark
if pattern == REMARK_RE or self.press:
while code:
for pattern, handler in Metar.remark_handlers:
for pattern, handler in self.remark_handlers:
if debug: print(handler.__name__,":",code)
m = pattern.match(code)
if m:
Expand All @@ -410,7 +410,7 @@ def __init__( self, metarcode, month=None, year=None, utcdelta=None):
raise ParserError("Unparsed groups in body '"+code+"' while processing '"+metarcode+"'")

def _do_trend_handlers(self, code):
for pattern, handler, repeatable in Metar.trend_handlers:
for pattern, handler, repeatable in self.trend_handlers:
if debug: print(handler.__name__,":",code)
m = pattern.match(code)
while m:
Expand Down
0