8000 Don't reference class attributes as class attributes within methods. by WeatherGod · Pull Request #37 · python-metar/python-metar · GitHub
[go: up one dir, main page]
Skip to content

Don't reference class attributes as class attributes within methods. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akrherz merged 1 commit into from
Jul 22, 2018
Merged

Don't reference class attributes as class attributes within methods. #37

akrherz merged 1 commit into from
Jul 22, 2018

Conversation

@WeatherGod
Copy link
Contributor
@WeatherGod WeatherGod commented Oct 12, 2017
  • This way, a subclass could create its own list of handlers, and the
    code would work just fine. This would allow users to create subclasses
    that can handle local variations of the Metar spec without changing
    the original Metar code.

@WeatherGod
Don't reference class attributes as class attributes within methods.
d66c4bf 
* This way, a subclass could create its own list of handlers, and the
  code would work just fine. This would allow users to create subclasses
  that can handle local variations of the Metar spec without changing
  the original Metar code.
@WeatherGod WeatherGod mentioned this pull request Oct 12, 2017
Closed
@WeatherGod
Copy link
Contributor Author
WeatherGod commented Oct 12, 2017

As an example of how this could be taken advantage of:

class SuperMetar(Metar.Metar):
    def __init__(self, *args, **kwargs):
        # Initialize additional attributes *before* calling super's
        # because that's where the parsing happens.
        self.auto_type = None
        self.lightning_reported = False
        super(SuperMetar, self).__init__(*args, **kwargs)

    def _handleAutoRemark(self, d):
        super(SuperMetar, self)._handleAutoRemark(d)
        self.auto_type = ''.join(['AO', d['type']])

    def _handleLightningRemark(self, d):
        super(SuperMetar, self)._handleLightningRemark(d)
        self.lightning_reported = True

    # Rebuild remark handler list, because it was built
    # against the original set of regexes and handlers.
    remark_handlers = [
            (regex, locals().get(func.__name__, func))
            for regex, func in Metar.Metar.remark_handlers]

@akrherz akrherz merged commit 22f0dd7 into python-metar:master Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WeatherGod @akrherz
0