10000 Mock asyncio.sleep for klapprotocol tests by rytilahti · Pull Request #1130 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]

Skip to content

Mock asyncio.sleep for klapprotocol tests #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented Sep 26, 2024

Speeds up tests in test_klapprotocol.py from 26s to 2s when there's no sleep between the retries.

Copy link
codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (5df6c76) to head (bb77f2a).
Report is 214 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
+ Coverage   92.60%   92.62%   +0.02%     
==========================================
  Files          96       96              
  Lines        6110     6117       +7     
  Branches     1506     1510       +4     
==========================================
+ Hits         5658     5666       +8     
+ Misses        354      353       -1     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti added this to the 0.7.4 milestone Sep 26, 2024
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Sep 27, 2024
@sdb9696 sdb9696 merged commit 8321fd0 into master Sep 27, 2024
30 checks passed
@sdb9696 sdb9696 deleted the janitor/speedup_test_klapprotocolk branch September 27, 2024 08:34
@sdb9696 sdb9696 mentioned this pull request Sep 27, 2024
sdb9696 added a commit that referenced this pull request Sep 27, 2024
## [0.7.4](https://github.com/python-kasa/python-kasa/tree/0.7.4) (2024-09-27)

[Full Changelog](0.7.3...0.7.4)

**Release summary:**

- KL135 color temp range corrected to 9000k max
- Minor enhancements and project maintenance

**Implemented enhancements:**

- Add factory\_reset\(\) to iotdevice [\#1125](#1125) (@rytilahti)
- Add reboot\(\) to the device interface [\#1124](#1124) (@rytilahti)
- Add factory-reset command to cli [\#1108](#1108) (@rytilahti)

**Fixed bugs:**

- Extend KL135 ct range up to 9000K [\#1123](#1123) (@rytilahti)
- Fix cli command for device off [\#1121](#1121) (@sdb9696)

**Project maintenance:**

- Use pytest-socket to ensure no tests are performing io [\#1133](#1133) (@sdb9696)
- Enable ruff lint pycodestyle warnings [\#1132](#1132) (@sdb9696)
- Add autouse fixture to patch asyncio.sleep [\#1131](#1131) (@sdb9696)
- Mock asyncio.sleep for klapprotocol tests [\#1130](#1130) (@rytilahti)
- Add fixture for T110 fw 1.9.0 [\#1129](#1129) (@rytilahti)
- Speed up and simplify github workflows [\#1128](#1128) (@sdb9696)
- Add KS200M\(US\) fw 1.0.12 fixture [\#1127](#1127) (@GatorEG)
- Add stale PR/Issue github workflow [\#1126](#1126) (@sdb9696)
- Add fixture for KL135\(US\) fw 1.0.15 [\#1122](#1122) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project improvements and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0