Speed up and simplify github workflows #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5287735 to
188a0fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 96 96
Lines 6117 6117
Branches 1510 1510
=======================================
Hits 5666 5666
Misses 353 353
Partials 98 98 ☔ View full report in Codecov by Sentry. |
sdb9696
commented
Sep 27, 2024
| uv run pre-commit run debug-statements --all-files | ||
| - name: "Run check-ast" | ||
|
|
||
| - name: "Run pre-commit checks" |
There was a problem hiding this comment.
Looks like we were missing the ruff format, check-yaml and doc8 from the CI. It's probably better to just run all the checks in a single step and pass --verbose to avoid having to keep them in sync.
There was a problem hiding this comment.
Yes, no need to repeat oneself here, I have been wanting to do this for a while 👍
sdb9696
commented
Sep 27, 2024
.github/actions/setup/action.yaml
Outdated
Comment on lines
20
to
24
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v2 | ||
| with: | ||
| enable-cache: true | ||
| cache-dependency-glob: "uv.lock" |
There was a problem hiding this comment.
This became an official astral action a few weeks ago and makes life so much easier that we don't have to do the pipx caching manually that we had to for poetry.
rytilahti
approved these changes
Sep 27, 2024
| uv run pre-commit run debug-statements --all-files | ||
| - name: "Run check-ast" | ||
|
|
||
| - name: "Run pre-commit checks" |
There was a problem hiding this comment.
Yes, no need to repeat oneself here, I have been wanting to do this for a while 👍
Merged
sdb9696
added a commit
that referenced
this pull request
Sep 27, 2024
## [0.7.4](https://github.com/python-kasa/python-kasa/tree/0.7.4) (2024-09-27) [Full Changelog](0.7.3...0.7.4) **Release summary:** - KL135 color temp range corrected to 9000k max - Minor enhancements and project maintenance **Implemented enhancements:** - Add factory\_reset\(\) to iotdevice [\#1125](#1125) (@rytilahti) - Add reboot\(\) to the device interface [\#1124](#1124) (@rytilahti) - Add factory-reset command to cli [\#1108](#1108) (@rytilahti) **Fixed bugs:** - Extend KL135 ct range up to 9000K [\#1123](#1123) (@rytilahti) - Fix cli command for device off [\#1121](#1121) (@sdb9696) **Project maintenance:** - Use pytest-socket to ensure no tests are performing io [\#1133](#1133) (@sdb9696) - Enable ruff lint pycodestyle warnings [\#1132](#1132) (@sdb9696) - Add autouse fixture to patch asyncio.sleep [\#1131](#1131) (@sdb9696) - Mock asyncio.sleep for klapprotocol tests [\#1130](#1130) (@rytilahti) - Add fixture for T110 fw 1.9.0 [\#1129](#1129) (@rytilahti) - Speed up and simplify github workflows [\#1128](#1128) (@sdb9696) - Add KS200M\(US\) fw 1.0.12 fixture [\#1127](#1127) (@GatorEG) - Add stale PR/Issue github workflow [\#1126](#1126) (@sdb9696) - Add fixture for KL135\(US\) fw 1.0.15 [\#1122](#1122) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astral-sh/setup-uvgithub actionpre-commitrun as a single job in CI instead of relisting each checkuvversion 0.4.16publish.ymlto useastral-sh/setup-uv